third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp - Issue 2733633002: Handle nested position:sticky elements correctly (compositor)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp

Issue 2733633002: Handle nested position:sticky elements correctly (compositor) (Closed)

Patch Set: Revert float changes to unittests too Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/property_tree.cc ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp

index ce5ddb73319dffff4ac917288477a1df61a414b2..2bd494decfda4c01ef7d4887b77edf117c14051a 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp

@@ -271,7 +271,7 @@ TEST_F(CompositingReasonFinderTest, RequiresCompositingForEffectAnimation) {

CompositingReasonFinder::requiresCompositingForEffectAnimation(*style));

}

-TEST_F(CompositingReasonFinderTest, DoNotCompositeNestedSticky) {

+TEST_F(CompositingReasonFinderTest, CompositeNestedSticky) {

ScopedCompositeFixedPositionForTest compositeFixedPosition(true);

setBodyInnerHTML(

@@ -300,7 +300,7 @@ TEST_F(CompositingReasonFinderTest, DoNotCompositeNestedSticky) {

ASSERT_TRUE(innerStickyLayer);

EXPECT_EQ(PaintsIntoOwnBacking, outerStickyLayer->compositingState());

- EXPECT_EQ(NotComposited, innerStickyLayer->compositingState());

+ EXPECT_EQ(PaintsIntoOwnBacking, innerStickyLayer->compositingState());

}

} // namespace blink