cc/layers/layer.cc - Issue 2733633002: Handle nested position:sticky elements correctly (compositor)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer.cc

Issue 2733633002: Handle nested position:sticky elements correctly (compositor) (Closed)

Patch Set: Revert float changes to unittests too Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/layer.cc

diff --git a/cc/layers/layer.cc b/cc/layers/layer.cc

index 9523b6241c1aba955cc95d86523742ee49ca7d22..4eaa09b4af69dc0365e41014028f8b22ab53c655 100644

--- a/cc/layers/layer.cc

+++ b/cc/layers/layer.cc

@@ -582,6 +582,9 @@ void Layer::SetPosition(const gfx::PointF& position) {

StickyPositionNodeData* sticky_data =

property_trees->transform_tree.StickyPositionData(

transform_tree_index());

+ // TODO(smcgruer): Pass main thread sticky-shifting offsets of

+ // non-promoted ancestors, or promote all ancestor sticky elements.

+ // See http://crbug.com/702229

sticky_data->main_thread_offset =

position.OffsetFromOrigin() -

sticky_data->constraints.parent_relative_sticky_box_offset