Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1292)

Unified Diff: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

Issue 2733633002: Handle nested position:sticky elements correctly (compositor) (Closed)
Patch Set: Use FindNodeIndexFromOwningLayerId Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
index 2be0d24562e3d5f081a766fa860aefd70bcc48a3..dfe4e23b0a22971ba78c55504d1f0f6f3e57fcc4 100644
--- a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
@@ -373,8 +373,8 @@ TEST_P(ScrollingCoordinatorTest, fastScrollingForStickyPosition) {
IntRect(constraint.scrollContainerRelativeStickyBoxRect));
EXPECT_EQ(IntRect(100, 100, 200, 200),
IntRect(constraint.scrollContainerRelativeContainingBlockRect));
- EXPECT_EQ(IntPoint(100, 100),
- IntPoint(constraint.parentRelativeStickyBoxOffset));
+ EXPECT_EQ(FloatPoint(100, 100),
+ FloatPoint(constraint.parentRelativeStickyBoxOffset));
}
{
Element* element = document->getElementById("div-tr");
@@ -448,8 +448,8 @@ TEST_P(ScrollingCoordinatorTest, fastScrollingForStickyPosition) {
IntRect(constraint.scrollContainerRelativeStickyBoxRect));
EXPECT_EQ(IntRect(100, 100, 200, 200),
IntRect(constraint.scrollContainerRelativeContainingBlockRect));
- EXPECT_EQ(IntPoint(0, 10),
- IntPoint(constraint.parentRelativeStickyBoxOffset));
+ EXPECT_EQ(FloatPoint(0, 10),
+ FloatPoint(constraint.parentRelativeStickyBoxOffset));
}
}

Powered by Google App Engine
This is Rietveld 408576698