third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h - Issue 2733633002: Handle nested position:sticky elements correctly (compositor)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h

Issue 2733633002: Handle nested position:sticky elements correctly (compositor) (Closed)

Patch Set: More layer id fixes Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/property_tree_builder.cc ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp ('k') | third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h

diff --git a/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h b/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h

index 84dab3cc2f76ad7170d18bed9235375e5dc16c62..cc60c139b029dac6e5a511591c5fb383ff0c21b4 100644

--- a/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h

+++ b/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h

@@ -113,6 +113,12 @@ class StickyPositionScrollingConstraints final {

return m_totalContainingBlockStickyOffset;

}

+ const LayoutBoxModelObject* nearestStickyAncestor() const {

+ return m_nearestStickyBoxShiftingStickyBox

+ ? m_nearestStickyBoxShiftingStickyBox

+ : m_nearestStickyBoxShiftingContainingBlock;

+ }

bool operator==(const StickyPositionScrollingConstraints& other) const {

return m_leftOffset == other.m_leftOffset &&

m_rightOffset == other.m_rightOffset &&