Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/layers/layer.cc

Issue 2733633002: Handle nested position:sticky elements correctly (compositor) (Closed)
Patch Set: Address reviewer comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/blink/web_layer_impl.cc ('k') | cc/layers/layer_sticky_position_constraint.h » ('j') | cc/trees/property_tree.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer.cc
diff --git a/cc/layers/layer.cc b/cc/layers/layer.cc
index c966f75f132a66ac259d56504e5e50b3ac9e336d..d39de4ef318246eed59820e35603eeed7e623a9d 100644
--- a/cc/layers/layer.cc
+++ b/cc/layers/layer.cc
@@ -589,6 +589,8 @@ void Layer::SetPosition(const gfx::PointF& position) {
StickyPositionNodeData* sticky_data =
property_trees->transform_tree.StickyPositionData(
transform_tree_index());
+ // TODO(smcgruer): Pass main thread sticky-shifting offsets of
+ // non-promoted ancestors, or promote all ancestor sticky elements.
flackr 2017/03/17 18:04:08 nit: Also bug link please?
smcgruer 2017/03/17 18:42:42 Done.
sticky_data->main_thread_offset =
position.OffsetFromOrigin() -
sticky_data->constraints.parent_relative_sticky_box_offset
« no previous file with comments | « cc/blink/web_layer_impl.cc ('k') | cc/layers/layer_sticky_position_constraint.h » ('j') | cc/trees/property_tree.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698