Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2424)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/trees/property_tree.h

Issue 2733633002: Handle nested position:sticky elements correctly (compositor) (Closed)
Patch Set: Fix unittest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/trees/draw_property_utils.cc ('K') | « cc/trees/layer_tree_host_common_unittest.cc ('k') | cc/trees/property_tree.cc » ('j') | cc/trees/property_tree.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/property_tree.h
diff --git a/cc/trees/property_tree.h b/cc/trees/property_tree.h
index 8c9d158a7bc28ee99741741d115eba725fbe0505..e325097b01116ee69604b36ec27b8ea6c1a65538 100644
--- a/cc/trees/property_tree.h
+++ b/cc/trees/property_tree.h
@@ -114,7 +114,13 @@ struct StickyPositionNodeData {
// by computing the additional offset necessary to keep the element stuck.
gfx::Vector2dF main_thread_offset;
- StickyPositionNodeData() : scroll_ancestor(-1) {}
+ int nearest_node_shifting_sticky_box;
flackr 2017/03/09 20:22:08 nit: Add a comment about these new members.
smcgruer 2017/03/10 16:37:10 Done.
+ int nearest_node_shifting_containing_block;
+
+ StickyPositionNodeData()
+ : scroll_ancestor(-1),
+ nearest_node_shifting_sticky_box(-1),
+ nearest_node_shifting_containing_block(-1) {}
};
class CC_EXPORT TransformTree final : public PropertyTree<TransformNode> {
« cc/trees/draw_property_utils.cc ('K') | « cc/trees/layer_tree_host_common_unittest.cc ('k') | cc/trees/property_tree.cc » ('j') | cc/trees/property_tree.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698