Handle nested position:sticky elements correctly (compositor)

third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
  *     documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
  * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
  * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebLayerStickyPositionConstraint_h
 #define WebLayerStickyPositionConstraint_h
 
-#include "public/platform/WebPoint.h"
-#include "public/platform/WebRect.h"
+#include "public/platform/WebFloatPoint.h"
+#include "public/platform/WebFloatRect.h"
+#include "public/platform/WebLayer.h"
 
 namespace blink {
 
 // TODO(flackr): Combine with WebLayerPositionConstraint.
 struct WebLayerStickyPositionConstraint {
   // True if the layer is sticky.
   bool isSticky : 1;
 
   // For each edge, true if the layer should stick to that edge of its
   // ancestor scroller (or the viewport).
   bool isAnchoredLeft : 1;
   bool isAnchoredRight : 1;
   bool isAnchoredTop : 1;
   bool isAnchoredBottom : 1;
 
   // For each edge, when the anchored bit above is set this gives the distance
   // to keep the element from that edge of the ancestor scroller or viewport.
   float leftOffset;
   float rightOffset;
   float topOffset;
   float bottomOffset;
 
   // This is the layout position of the sticky element before it has been
   // shifted relative to the enclosing composited layer.
-  WebPoint parentRelativeStickyBoxOffset;
+  WebFloatPoint parentRelativeStickyBoxOffset;

[chrishtr, 2017/03/20 17:24:52]

Are these now floating-point to account for adding subpixel sticky offsets? If
so,
how is snapping done in the compositor?

[smcgruer, 2017/03/21 13:54:55]

This came about due to flackr's concerns about losing precision in
total_sticky_box_sticky_offset and total_containing_block_sticky_offset in
patchset 5. Once those were float, there was then a natural progression to clean
things up, including parentRelativeStickyBoxOffset which was created from a
float (the old stickyBoxOffset in CompositedLayerMapping) and was used to set a
Vector2dF (main_thread_offset).

I guess there is a question here as to whether it is correct to remove the
rounding that was previously applied to parentRelativeStickyBoxOffset via
'roundedIntPoint'?

(The output of the cc side is and always was a Vector2dF, which is incorporated
as a translate Transform).

[smcgruer, 2017/03/21 16:01:25]

Discussed with flackr. I overreached in my cleanup attempts. :D. Will move the
parentRelativeStickyBoxOffset back to WebPoint.

[smcgruer, 2017/03/21 17:37:48]

Done.

 
   // The layout rectangle of the sticky element before it has been shifted
   // to stick.
-  WebRect scrollContainerRelativeStickyBoxRect;
+  WebFloatRect scrollContainerRelativeStickyBoxRect;
 
   // The layout rectangle of the containing block edges which this sticky
   // element should not be shifted beyond.
-  WebRect scrollContainerRelativeContainingBlockRect;
+  WebFloatRect scrollContainerRelativeContainingBlockRect;
+
+  // The nearest ancestor sticky layers that affect the sticky box constraint
+  // rect and the containing block constraint rect respectively.
+  int nearestLayerShiftingStickyBox;
+  int nearestLayerShiftingContainingBlock;
 
   WebLayerStickyPositionConstraint()
       : isSticky(false),
         isAnchoredLeft(false),
         isAnchoredRight(false),
         isAnchoredTop(false),
         isAnchoredBottom(false),
         leftOffset(0.f),
         rightOffset(0.f),
         topOffset(0.f),
-        bottomOffset(0.f) {}
+        bottomOffset(0.f),
+        nearestLayerShiftingStickyBox(WebLayer::kInvalidLayerId),
+        nearestLayerShiftingContainingBlock(WebLayer::kInvalidLayerId) {}
 };
 
 }  // namespace blink
 
 #endif  // WebLayerStickyPositionConstraint_h