Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: cc/layers/layer_sticky_position_constraint.h

Issue 2733633002: Handle nested position:sticky elements correctly (compositor) (Closed)
Patch Set: Address reviewer comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_LAYERS_LAYER_STICKY_POSITION_CONSTRAINT_H_ 5 #ifndef CC_LAYERS_LAYER_STICKY_POSITION_CONSTRAINT_H_
6 #define CC_LAYERS_LAYER_STICKY_POSITION_CONSTRAINT_H_ 6 #define CC_LAYERS_LAYER_STICKY_POSITION_CONSTRAINT_H_
7 7
8 #include "cc/base/cc_export.h" 8 #include "cc/base/cc_export.h"
9 9
10 #include "ui/gfx/geometry/rect.h" 10 #include "ui/gfx/geometry/point_f.h"
11 #include "ui/gfx/geometry/rect_f.h"
12 #include "ui/gfx/geometry/vector2d_f.h"
11 13
12 namespace cc { 14 namespace cc {
13 15
14 struct CC_EXPORT LayerStickyPositionConstraint { 16 struct CC_EXPORT LayerStickyPositionConstraint {
15 LayerStickyPositionConstraint(); 17 LayerStickyPositionConstraint();
16 LayerStickyPositionConstraint(const LayerStickyPositionConstraint& other); 18 LayerStickyPositionConstraint(const LayerStickyPositionConstraint& other);
17 19
18 bool is_sticky : 1; 20 bool is_sticky : 1;
19 bool is_anchored_left : 1; 21 bool is_anchored_left : 1;
20 bool is_anchored_right : 1; 22 bool is_anchored_right : 1;
21 bool is_anchored_top : 1; 23 bool is_anchored_top : 1;
22 bool is_anchored_bottom : 1; 24 bool is_anchored_bottom : 1;
23 25
24 // The offset from each edge of the ancestor scroller (or the viewport) to 26 // The offset from each edge of the ancestor scroller (or the viewport) to
25 // try to maintain to the sticky box as we scroll. 27 // try to maintain to the sticky box as we scroll.
26 float left_offset; 28 float left_offset;
27 float right_offset; 29 float right_offset;
28 float top_offset; 30 float top_offset;
29 float bottom_offset; 31 float bottom_offset;
30 32
31 // The layout offset of the sticky box relative to its containing layer. 33 // The layout offset of the sticky box relative to its containing layer.
32 // This is used to detect the sticky offset the main thread has applied 34 // This is used to detect the sticky offset the main thread has applied
33 // to the layer. 35 // to the layer.
34 gfx::Point parent_relative_sticky_box_offset; 36 gfx::PointF parent_relative_sticky_box_offset;
35 37
36 // The rectangle corresponding to original layout position of the sticky box 38 // The rectangle corresponding to original layout position of the sticky box
37 // relative to the scroll ancestor. The sticky box is only offset once the 39 // relative to the scroll ancestor. The sticky box is only offset once the
38 // scroll has passed its initial position (e.g. top_offset will only push 40 // scroll has passed its initial position (e.g. top_offset will only push
39 // the element down from its original position). 41 // the element down from its original position).
40 gfx::Rect scroll_container_relative_sticky_box_rect; 42 gfx::RectF scroll_container_relative_sticky_box_rect;
41 43
42 // The layout rectangle of the sticky box's containing block relative to the 44 // The layout rectangle of the sticky box's containing block relative to the
43 // scroll ancestor. The sticky box is only moved as far as its containing 45 // scroll ancestor. The sticky box is only moved as far as its containing
44 // block boundary. 46 // block boundary.
45 gfx::Rect scroll_container_relative_containing_block_rect; 47 gfx::RectF scroll_container_relative_containing_block_rect;
48
49 // The nearest ancestor sticky layer ids that affect the sticky box constraint
50 // rect and the containing block constraint rect respectively. If no such
51 // layer exists, these are set to Layer::INVALID_ID.
52 int nearest_layer_shifting_sticky_box;
53 int nearest_layer_shifting_containing_block;
54
55 // Returns the nearest sticky ancestor layer, or Layer::INVALID_ID if no such
56 // layer exists.
57 int NearestStickyAncestor();
46 58
47 bool operator==(const LayerStickyPositionConstraint&) const; 59 bool operator==(const LayerStickyPositionConstraint&) const;
48 bool operator!=(const LayerStickyPositionConstraint&) const; 60 bool operator!=(const LayerStickyPositionConstraint&) const;
49 }; 61 };
50 62
51 } // namespace cc 63 } // namespace cc
52 64
53 #endif // CC_LAYERS_LAYER_STICKY_POSITION_CONSTRAINT_H_ 65 #endif // CC_LAYERS_LAYER_STICKY_POSITION_CONSTRAINT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698