Issue 2733613002: Added comments explaining why some code is not used / returns empty results as a result of issue #2…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2733613002: Added comments explaining why some code is not used / returns empty results as a result of issue #2… (Closed)

Created:
3 years, 9 months ago by bkonyi

Modified:
3 years, 9 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Added comments explaining why some code is not used / returns empty results as a result of issue #28885 BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/f31c653b54d6826fb46ef84cb4a0bbcfc895272a

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -0 lines)			Patch
M	runtime/observatory/lib/src/elements/isolate_view.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/observatory/lib/src/service/object.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/zone.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

bkonyi

3 years, 9 months ago (2017-03-03 20:23:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f31c653b54d6826fb46ef84cb4a0bbcfc895272a (presubmit successful).