Tapping/longpressing should result in INSERTION_HANDLE_SHOWN

ui/touch_selection/touch_selection_controller_unittest.cc

Index: ui/touch_selection/touch_selection_controller_unittest.cc
diff --git a/ui/touch_selection/touch_selection_controller_unittest.cc b/ui/touch_selection/touch_selection_controller_unittest.cc
index 6093e1799805c22f4a28c9f63b5e2ca19a3e6730..93ffa2e0be769a41b5243ac94e95d2af05204bd1 100644
--- a/ui/touch_selection/touch_selection_controller_unittest.cc
+++ b/ui/touch_selection/touch_selection_controller_unittest.cc
@@ -255,6 +255,12 @@ TEST_F(TouchSelectionControllerTest, InsertionBasic) {
   EXPECT_THAT(GetAndResetEvents(), ElementsAre(INSERTION_HANDLE_MOVED));
   EXPECT_EQ(insertion_rect.bottom_left(), GetLastEventStart());
 
+  OnTapEvent();
+  insertion_rect.Offset(1, 0);
+  ChangeInsertion(insertion_rect, visible);
+  EXPECT_THAT(GetAndResetEvents(), ElementsAre(INSERTION_HANDLE_SHOWN));
+  EXPECT_EQ(insertion_rect.bottom_left(), GetLastEventStart());
+
   ClearInsertion();
   EXPECT_THAT(GetAndResetEvents(),
               ElementsAre(INSERTION_HANDLE_CLEARED));
@@ -482,7 +488,6 @@ TEST_F(TouchSelectionControllerTest, InsertionNotResetByRepeatedTapOrPress) {
   EXPECT_EQ(anchor_rect.bottom_left(), GetLastEventStart());
 
   // Tapping again shouldn't reset the active insertion point.
-  OnTapEvent();

[mohsen, 2017/03/07 03:30:10]

Can you explain why this is removed. We are simulating a tap, so it seems that
OnTapEvent() should be called. BTW, is this test
(InsertionNotResetByRepeatedTapOrPress) still relevant after your change?

[amaralp, 2017/03/07 04:20:38]

Tapping on the handle will cause
|TouchSelectionController::WillHandleTouchEvent()| to return |true| which means
that the tap will not get propagated. So |OnTapEvent()| shouldn't be called in
this scenario.
Since |OnTapEvent()| and |OnLongpressEvent()| shouldn't be called when the event
hits a touch handle |InsertionNotResetByRepeatedTapOrPress| is covered by
|InsertionTapped|.

   MockMotionEvent event(MockMotionEvent::ACTION_DOWN, event_time, 0, 0);
   EXPECT_TRUE(controller().WillHandleTouchEvent(event));
   EXPECT_THAT(GetAndResetEvents(), ElementsAre(INSERTION_HANDLE_DRAG_STARTED));