Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 27336: Hook up upstreamed V8 bindings, Chromium side (Closed)

Created:
11 years, 9 months ago by dglazkov
Modified:
9 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Hook up upstreamed V8 bindings, Chromium side R=mark Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10713

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -2029 lines) Patch
M webkit/build/V8Bindings/SConscript View 2 chunks +24 lines, -6 lines 0 comments Download
M webkit/build/V8Bindings/V8Bindings.vcproj View 3 chunks +165 lines, -77 lines 0 comments Download
D webkit/port/bindings/v8/ScheduledAction.h View 1 chunk +0 lines, -21 lines 0 comments Download
D webkit/port/bindings/v8/ScriptCachedFrameData.h View 1 chunk +0 lines, -52 lines 0 comments Download
D webkit/port/bindings/v8/ScriptCallFrame.h View 1 chunk +0 lines, -75 lines 0 comments Download
D webkit/port/bindings/v8/ScriptCallFrame.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
D webkit/port/bindings/v8/ScriptCallStack.h View 1 chunk +0 lines, -59 lines 0 comments Download
D webkit/port/bindings/v8/ScriptCallStack.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
D webkit/port/bindings/v8/ScriptInstance.h View 1 chunk +0 lines, -63 lines 0 comments Download
D webkit/port/bindings/v8/ScriptInstance.cpp View 1 chunk +0 lines, -83 lines 0 comments Download
D webkit/port/bindings/v8/ScriptSourceCode.h View 1 chunk +0 lines, -72 lines 0 comments Download
D webkit/port/bindings/v8/ScriptState.h View 1 chunk +0 lines, -50 lines 0 comments Download
D webkit/port/bindings/v8/ScriptString.h View 1 chunk +0 lines, -66 lines 0 comments Download
D webkit/port/bindings/v8/ScriptValue.h View 1 chunk +0 lines, -129 lines 0 comments Download
D webkit/port/bindings/v8/ScriptValue.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
M webkit/port/bindings/v8/v8_custom.cpp View 7 chunks +2 lines, -1075 lines 0 comments Download
M webkit/webkit.gyp View 4 chunks +1 line, -28 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dglazkov
11 years, 9 months ago (2009-03-02 17:19:31 UTC) #1
Mark Mentovai
11 years, 9 months ago (2009-03-02 17:22:49 UTC) #2
Most excellent.  If it builds, it LGTM.

Powered by Google App Engine
This is Rietveld 408576698