Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js

Issue 2733593002: Text control elements should contain all (shadow DOM) children. (Closed)
Patch Set: Improve documentation. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-click-in-iframe.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js
diff --git a/third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js b/third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js
index ad704dab940268a440a13c26d4351ba34257fe45..404031a613dace92d8dee0181973f394fb91897d 100644
--- a/third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js
+++ b/third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js
@@ -32,7 +32,8 @@ function testSpinButtonChangeAndInputEvents(inputType, initialValue, expectedVal
debug('Click the upper button');
// Move the cursor on the upper button.
var spinButton = getElementByPseudoId(internals.oldestShadowRoot(testInput), "-webkit-inner-spin-button");
- eventSender.mouseMoveTo(testInput.offsetLeft + spinButton.offsetLeft, testInput.offsetTop + testInput.offsetHeight / 4);
+ var rect = spinButton.getBoundingClientRect();
+ eventSender.mouseMoveTo(rect.left, rect.top + rect.height / 4);
eventSender.mouseDown();
debug('Triggers only input event on mouseDown');
shouldBeEqualToString('testInput.value', expectedValue);
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/forms/resources/common-spinbutton-click-in-iframe.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698