[ic] Inline LoadIC into LdaNamedProperty bytecode handler

src/interpreter/interpreter.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/interpreter.h"
 
 #include <fstream>
 #include <memory>
 
 #include "src/ast/prettyprinter.h"
@@ skipping 467 matching lines @@
 //
 // Stores the value of register <src> to register <dst>.
 void Interpreter::DoMov(InterpreterAssembler* assembler) {
   Node* src_index = __ BytecodeOperandReg(0);
   Node* src_value = __ LoadRegister(src_index);
   Node* dst_index = __ BytecodeOperandReg(1);
   __ StoreRegister(src_value, dst_index);
   __ Dispatch();
 }
 
-void Interpreter::BuildLoadGlobal(int slot_operand_index,
-                                  int name_operand_index,
-                                  TypeofMode typeof_mode,
-                                  InterpreterAssembler* assembler) {
+void Interpreter::BuildLoadGlobalIC(int slot_operand_index,
+                                    int name_operand_index,
+                                    TypeofMode typeof_mode,
+                                    InterpreterAssembler* assembler) {
+  // Must be kept in sync with AccessorAssembler::LoadGlobalIC.
+
   // Load the global via the LoadGlobalIC.
   Node* feedback_vector = __ LoadFeedbackVector();
   Node* feedback_slot = __ BytecodeOperandIdx(slot_operand_index);
 
   AccessorAssembler accessor_asm(assembler->state());
 
   Label try_handler(assembler, Label::kDeferred),
       miss(assembler, Label::kDeferred);
 
   // Fast path without frame construction for the data case.
@@ skipping 51 matching lines @@
 }
 
 // LdaGlobal <name_index> <slot>
 //
 // Load the global with name in constant pool entry <name_index> into the
 // accumulator using FeedBackVector slot <slot> outside of a typeof.
 void Interpreter::DoLdaGlobal(InterpreterAssembler* assembler) {
   static const int kNameOperandIndex = 0;
   static const int kSlotOperandIndex = 1;
 
-  BuildLoadGlobal(kSlotOperandIndex, kNameOperandIndex, NOT_INSIDE_TYPEOF,
-                  assembler);
+  BuildLoadGlobalIC(kSlotOperandIndex, kNameOperandIndex, NOT_INSIDE_TYPEOF,
+                    assembler);
 }
 
 // LdaGlobalInsideTypeof <name_index> <slot>
 //
 // Load the global with name in constant pool entry <name_index> into the
 // accumulator using FeedBackVector slot <slot> inside of a typeof.
 void Interpreter::DoLdaGlobalInsideTypeof(InterpreterAssembler* assembler) {
   static const int kNameOperandIndex = 0;
   static const int kSlotOperandIndex = 1;
 
-  BuildLoadGlobal(kSlotOperandIndex, kNameOperandIndex, INSIDE_TYPEOF,
-                  assembler);
+  BuildLoadGlobalIC(kSlotOperandIndex, kNameOperandIndex, INSIDE_TYPEOF,
+                    assembler);
 }
 
 void Interpreter::DoStaGlobal(Callable ic, InterpreterAssembler* assembler) {
   // Get the global object.
   Node* context = __ GetContext();
   Node* native_context = __ LoadNativeContext(context);
   Node* global =
       __ LoadContextElement(native_context, Context::EXTENSION_INDEX);
 
   // Store the global via the StoreIC.
@@ skipping 183 matching lines @@
 
   // Fast path does a normal load global
   {
     static const int kNameOperandIndex = 0;
     static const int kSlotOperandIndex = 1;
 
     TypeofMode typeof_mode = function_id == Runtime::kLoadLookupSlotInsideTypeof
                                  ? INSIDE_TYPEOF
                                  : NOT_INSIDE_TYPEOF;
 
-    BuildLoadGlobal(kSlotOperandIndex, kNameOperandIndex, typeof_mode,
-                    assembler);
+    BuildLoadGlobalIC(kSlotOperandIndex, kNameOperandIndex, typeof_mode,
+                      assembler);
   }
 
   // Slow path when we have to call out to the runtime
   __ Bind(&slowpath);
   {
     Node* name_index = __ BytecodeOperandIdx(0);
     Node* name = __ LoadConstantPoolEntry(name_index);
     Node* result = __ CallRuntime(function_id, context, name);
     __ SetAccumulator(result);
     __ Dispatch();
@@ skipping 40 matching lines @@
 }
 
 // StaLookupSlotStrict <name_index>
 //
 // Store the object in accumulator to the object with the name in constant
 // pool entry |name_index| in strict mode.
 void Interpreter::DoStaLookupSlotStrict(InterpreterAssembler* assembler) {
   DoStaLookupSlot(LanguageMode::STRICT, assembler);
 }
 
+void Interpreter::BuildLoadIC(int recv_operand_index, int slot_operand_index,
+                              int name_operand_index,
+                              InterpreterAssembler* assembler) {
+  // Must be kept in sync with AccessorAssembler::LoadIC.

[Igor Sheludko, 2017/03/03 15:29:44]

Please move the LoadIC related piece to AccessorAssembler. Feel free to use
lambdas.

[jgruber, 2017/03/03 17:53:42]

Done. I left optimizations like delayed loading and removal of useless smi
untagging out of this CL so no lambdas needed.

+  __ Comment("BuildLoadIC");
+
+  // Load vector and slot.
+  Node* feedback_vector = __ LoadFeedbackVector();
+  Node* feedback_slot = __ BytecodeOperandIdx(slot_operand_index);
+  Node* smi_slot = __ SmiTag(feedback_slot);
+
+  // Load receiver.
+  Node* register_index = __ BytecodeOperandReg(recv_operand_index);
+  Node* recv = __ LoadRegister(register_index);
+
+  // Load the name.
+  // TODO(jgruber): Not needed for monomorphic smi handler constant/field case.
+  Node* constant_index = __ BytecodeOperandIdx(name_operand_index);
+  Node* name = __ LoadConstantPoolEntry(constant_index);
+
+  Label done(assembler), stub_call(assembler, Label::kDeferred),
+      miss(assembler, Label::kDeferred);
+
+  Variable var_result(assembler, MachineRepresentation::kTagged);
+  ExitPoint exit_point(assembler, &done, &var_result);
+
+  // Inlined fast path for the monomorphic case.
+  {
+    __ Comment("BuildLoadIC_fast");
+
+    AccessorAssembler accessor_asm(assembler->state());
+
+    Node* recv_map = __ LoadReceiverMap(recv);
+    __ GotoIf(__ IsDeprecatedMap(recv_map), &miss);
+
+    Node* feedback = nullptr;
+    Node* handler = nullptr;
+    std::tie(feedback, handler) = accessor_asm.TryMonomorphicCase(
+        smi_slot, feedback_vector, recv_map, &stub_call);
+
+    Node* context = __ GetContext();
+    AccessorAssembler::LoadICParameters params(context, recv, name, smi_slot,
+                                               feedback_vector);
+    accessor_asm.HandleLoadICHandlerCase(&params, handler, &miss, &exit_point);
+  }
+
+  __ Bind(&stub_call);
+  {
+    __ Comment("BuildLoadIC_noninlined");
+
+    Callable ic = CodeFactory::LoadICInOptimizedCode_Noninlined(isolate_);
+    Node* code_target = __ HeapConstant(ic.code());
+    Node* context = __ GetContext();
+    exit_point.ReturnCallStub(ic.descriptor(), code_target, context, recv, name,
+                              smi_slot, feedback_vector);
+  }
+
+  __ Bind(&miss);
+  {
+    __ Comment("BuildLoadIC_miss");
+
+    Node* context = __ GetContext();
+    exit_point.ReturnCallRuntime(Runtime::kLoadIC_Miss, context, recv, name,
+                                 smi_slot, feedback_vector);
+  }
+
+  __ Bind(&done);
+  {
+    __ SetAccumulator(var_result.value());
+    __ Dispatch();
+  }
+}
+
 // LdaNamedProperty <object> <name_index> <slot>
 //
 // Calls the LoadIC at FeedBackVector slot <slot> for <object> and the name at
 // constant pool entry <name_index>.
 void Interpreter::DoLdaNamedProperty(InterpreterAssembler* assembler) {
-  Callable ic = CodeFactory::LoadICInOptimizedCode(isolate_);
-  Node* code_target = __ HeapConstant(ic.code());
-  Node* register_index = __ BytecodeOperandReg(0);
-  Node* object = __ LoadRegister(register_index);
-  Node* constant_index = __ BytecodeOperandIdx(1);
-  Node* name = __ LoadConstantPoolEntry(constant_index);
-  Node* raw_slot = __ BytecodeOperandIdx(2);
-  Node* smi_slot = __ SmiTag(raw_slot);
-  Node* feedback_vector = __ LoadFeedbackVector();
-  Node* context = __ GetContext();
-  Node* result = __ CallStub(ic.descriptor(), code_target, context, object,
-                             name, smi_slot, feedback_vector);
-  __ SetAccumulator(result);
-  __ Dispatch();
+  static const int kRecvOperandIndex = 0;
+  static const int kNameOperandIndex = 1;
+  static const int kSlotOperandIndex = 2;
+
+  BuildLoadIC(kRecvOperandIndex, kSlotOperandIndex, kNameOperandIndex,
+              assembler);
 }
 
 // KeyedLoadIC <object> <slot>
 //
 // Calls the KeyedLoadIC at FeedBackVector slot <slot> for <object> and the key
 // in the accumulator.
 void Interpreter::DoLdaKeyedProperty(InterpreterAssembler* assembler) {
   Callable ic = CodeFactory::KeyedLoadICInOptimizedCode(isolate_);
   Node* code_target = __ HeapConstant(ic.code());
   Node* reg_index = __ BytecodeOperandReg(0);
@@ skipping 2509 matching lines @@
   __ StoreObjectField(generator, JSGeneratorObject::kContinuationOffset,
       __ SmiTag(new_state));
   __ SetAccumulator(old_state);
 
   __ Dispatch();
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8