[ic] Inline LoadIC into LdaNamedProperty bytecode handler

src/ic/accessor-assembler.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_SRC_IC_ACCESSOR_ASSEMBLER_H_
 #define V8_SRC_IC_ACCESSOR_ASSEMBLER_H_
 
 #include "src/code-stub-assembler.h"
 
 namespace v8 {
 namespace internal {
 
 namespace compiler {
 class CodeAssemblerState;
 }
 
 class ExitPoint;
 
 class AccessorAssembler : public CodeStubAssembler {
  public:
   typedef compiler::Node Node;
 
   explicit AccessorAssembler(compiler::CodeAssemblerState* state)
       : CodeStubAssembler(state) {}
 
   void GenerateLoadIC();
+  void GenerateLoadIC_Noninlined();
   void GenerateLoadIC_Uninitialized();
   void GenerateLoadField();
   void GenerateLoadICTrampoline();
   void GenerateKeyedLoadIC();
   void GenerateKeyedLoadICTrampoline();
   void GenerateKeyedLoadIC_Megamorphic();
   void GenerateStoreIC(LanguageMode language_mode);
   void GenerateStoreICTrampoline(LanguageMode language_mode);
 
   void GenerateLoadICProtoArray(bool throw_reference_error_if_nonexistent);
@@ skipping 32 matching lines @@
   };
 
   void LoadGlobalIC_TryPropertyCellCase(
       Node* vector, Node* slot, ExitPoint* exit_point, Label* try_handler,
       Label* miss, ParameterMode slot_mode = SMI_PARAMETERS);
   void LoadGlobalIC_TryHandlerCase(const LoadICParameters* p,
                                    TypeofMode typeof_mode,
                                    ExitPoint* exit_point, Label* miss);
   void LoadGlobalIC_MissCase(const LoadICParameters* p, ExitPoint* exit_point);
 
+  // Checks monomorphic case. There are two variants: the first returns a
+  // ({feedback}, {handler}) pair and falls through on success, while the second
+  // stores {handler} in the given variable and jumps to {if_handler} on
+  // success.
+  std::pair<Node*, Node*> TryMonomorphicCase(Node* slot, Node* vector,
+                                             Node* receiver_map,
+                                             Label* if_miss);
+  Node* TryMonomorphicCase(Node* slot, Node* vector, Node* receiver_map,
+                           Label* if_handler, Variable* var_handler,
+                           Label* if_miss);
+
+  enum ElementSupport { kOnlyProperties, kSupportElements };
+  void HandleLoadICHandlerCase(
+      const LoadICParameters* p, Node* handler, Label* miss,
+      ExitPoint* exit_point, ElementSupport support_elements = kOnlyProperties);
+
  protected:
   struct StoreICParameters : public LoadICParameters {
     StoreICParameters(Node* context, Node* receiver, Node* name, Node* value,
                       Node* slot, Node* vector)
         : LoadICParameters(context, receiver, name, slot, vector),
           value(value) {}
     Node* value;
   };
 
-  enum ElementSupport { kOnlyProperties, kSupportElements };
   void HandleStoreICHandlerCase(
       const StoreICParameters* p, Node* handler, Label* miss,
       ElementSupport support_elements = kOnlyProperties);
   void JumpIfDataProperty(Node* details, Label* writable, Label* readonly);
 
  private:
   // Stub generation entry points.
 
+  // LoadIC contains the full LoadIC logic, while LoadIC_Noninlined contains
+  // logic not inlined into Ignition bytecode handlers.
   void LoadIC(const LoadICParameters* p);
+  void LoadIC_Noninlined(const LoadICParameters* p, Node* receiver_map,
+                         Node* feedback, Variable* var_handler,
+                         Label* if_handler, Label* miss, ExitPoint* exit_point);
+
   void LoadIC_Uninitialized(const LoadICParameters* p);
   void LoadICProtoArray(const LoadICParameters* p, Node* handler,
                         bool throw_reference_error_if_nonexistent);
   void LoadGlobalIC(const LoadICParameters* p, TypeofMode typeof_mode);
   void KeyedLoadIC(const LoadICParameters* p);
   void KeyedLoadICGeneric(const LoadICParameters* p);
   void StoreIC(const StoreICParameters* p);
   void KeyedStoreIC(const StoreICParameters* p, LanguageMode language_mode);
 
   // IC dispatcher behavior.
-
-  // Checks monomorphic case. Returns {feedback} entry of the vector.
-  Node* TryMonomorphicCase(Node* slot, Node* vector, Node* receiver_map,
-                           Label* if_handler, Variable* var_handler,
-                           Label* if_miss);
   void HandlePolymorphicCase(Node* receiver_map, Node* feedback,
                              Label* if_handler, Variable* var_handler,
                              Label* if_miss, int unroll_count);
   void HandleKeyedStorePolymorphicCase(Node* receiver_map, Node* feedback,
                                        Label* if_handler, Variable* var_handler,
                                        Label* if_transition_handler,
                                        Variable* var_transition_map_cell,
                                        Label* if_miss);
 
   // LoadIC implementation.
 
-  void HandleLoadICHandlerCase(
-      const LoadICParameters* p, Node* handler, Label* miss,
-      ElementSupport support_elements = kOnlyProperties);
-
   void HandleLoadICSmiHandlerCase(const LoadICParameters* p, Node* holder,
                                   Node* smi_handler, Label* miss,
                                   ExitPoint* exit_point,
                                   ElementSupport support_elements);
 
   void HandleLoadICProtoHandlerCase(const LoadICParameters* p, Node* handler,
                                     Variable* var_holder,
                                     Variable* var_smi_handler,
                                     Label* if_smi_handler, Label* miss,
                                     ExitPoint* exit_point,
@@ skipping 41 matching lines @@
                            Node* instance_type, Node* key,
                            const LoadICParameters* p, Label* slow,
                            UseStubCache use_stub_cache = kUseStubCache);
 
   // Low-level helpers.
 
   Node* PrepareValueForStore(Node* handler_word, Node* holder,
                              Representation representation, Node* transition,
                              Node* value, Label* bailout);
 
+  Node* LoadFeedbackSlot(Node* vector, Node* slot, int additional_offset);
+
   // Extends properties backing store by JSObject::kFieldsAdded elements.
   void ExtendPropertiesBackingStore(Node* object);
 
   void StoreNamedField(Node* handler_word, Node* object, bool is_inobject,
                        Representation representation, Node* value,
                        bool transition_to_field, Label* bailout);
 
   void EmitFastElementsBoundsCheck(Node* object, Node* elements,
                                    Node* intptr_index,
                                    Node* is_jsarray_condition, Label* miss);
@@ skipping 85 matching lines @@
 
   CodeAssemblerLabel* const out_;
   CodeAssemblerVariable* const var_result_;
   CodeStubAssembler* const asm_;
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_SRC_IC_ACCESSOR_ASSEMBLER_H_