chrome/browser/android/webapk/webapk_install_service.cc - Issue 2733543002: [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 1/3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapk/webapk_install_service.cc

Issue 2733543002: [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 1/3 (Closed)

Patch Set: Merge branch 'refactor_shortcut_helper29' into refactor_shortcut_helper3 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/webapk/webapk_install_service.cc

diff --git a/chrome/browser/android/webapk/webapk_install_service.cc b/chrome/browser/android/webapk/webapk_install_service.cc

index 153543f1ffd1373416b10988958d1fb34f0d05e5..644fd0e8d1a5cc061d81ee2ea6dc5b9ed9c61dce 100644

--- a/chrome/browser/android/webapk/webapk_install_service.cc

+++ b/chrome/browser/android/webapk/webapk_install_service.cc

@@ -63,8 +63,8 @@ void WebApkInstallService::UpdateAsync(

void WebApkInstallService::OnFinishedInstall(

const GURL& web_manifest_url,

const FinishCallback& finish_callback,

- bool success,

+ WebApkInstallResult result,

const std::string& webapk_package_name) {

- finish_callback.Run(success, webapk_package_name);

+ finish_callback.Run(result, webapk_package_name);

installs_.erase(web_manifest_url);

}