[Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 1/3

chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
 import android.content.pm.PackageInfo;
 import android.content.pm.PackageManager;
 import android.graphics.Bitmap;
 import android.text.TextUtils;
@@ skipping 132 matching lines @@
         //
         // If the Web Manifest was not found and an upgrade is not requested, keep on fetching
         // Web Manifests as the user navigates. For instance, the WebAPK's start_url might not
         // point to a Web Manifest because start_url redirects to the WebAPK's main page.
         if (gotManifest || needsUpgrade) {
             destroyFetcher();
         }
 
         if (!needsUpgrade) {
             if (!mStorage.didPreviousUpdateSucceed()) {
-                recordUpdate(mStorage, true /* success */, false /* relaxUpdates */);
+                recordUpdate(mStorage, WebApkInstallResult.SUCCESS, false /* relaxUpdates */);
             }
             return;
         }
 
         // Set WebAPK update as having failed in case that Chrome is killed prior to
         // {@link onBuiltWebApk} being called.
-        recordUpdate(mStorage, false /* success */, false /* relaxUpdates*/);
+        recordUpdate(mStorage, WebApkInstallResult.FAILURE, false /* relaxUpdates*/);
 
         if (fetchedInfo != null) {
             scheduleUpdate(fetchedInfo, bestIconUrl, false /* isManifestStale */);
             return;
         }
 
         // Tell the server that the our version of the Web Manifest might be stale and to ignore
         // our Web Manifest data if the server's Web Manifest data is newer. This scenario can
         // occur if the Web Manifest is temporarily unreachable.
         scheduleUpdate(mInfo, "" /* bestIconUrl */, true /* isManifestStale */);
@@ skipping 119 matching lines @@
         if (isShellApkVersionOutOfDate(info)) return true;
 
         return mStorage.shouldCheckForUpdate();
     }
 
     /**
      * Updates {@link WebappDataStorage} with the time of the latest WebAPK update and whether the
      * WebAPK update succeeded.
      */
     private static void recordUpdate(
-            WebappDataStorage storage, boolean success, boolean relaxUpdates) {
+            WebappDataStorage storage, int webApkInstallResult, boolean relaxUpdates) {
         // Update the request time and result together. It prevents getting a correct request time
         // but a result from the previous request.
         storage.updateTimeOfLastWebApkUpdateRequestCompletion();
-        storage.updateDidLastWebApkUpdateRequestSucceed(success);
+        storage.updateDidLastWebApkUpdateRequestSucceed(
+                webApkInstallResult == WebApkInstallResult.SUCCESS);
         storage.setRelaxedUpdates(relaxUpdates);
     }
 
     /**
      * Checks whether the WebAPK needs to be updated.
      * @param info               Meta data from WebAPK's Android Manifest.
      * @param fetchedInfo        Fetched data for Web Manifest.
      * @param bestFetchedIconUrl The icon URL in {@link fetchedInfo#iconUrlToMurmur2HashMap()} best
      *                           suited for use as the launcher icon on this device.
      */
@@ skipping 37 matching lines @@
      */
     protected boolean urlsMatchIgnoringFragments(String url1, String url2) {
         return UrlUtilities.urlsMatchIgnoringFragments(url1, url2);
     }
 
     /**
      * Called after either a request to update the WebAPK has been sent or the update process
      * fails.
      */
     @CalledByNative
-    private static void onBuiltWebApk(String id, boolean success, boolean relaxUpdates) {
+    private static void onBuiltWebApk(String id, int webApkInstallResult, boolean relaxUpdates) {
         WebappDataStorage storage = WebappRegistry.getInstance().getWebappDataStorage(id);
         if (storage == null) return;
 
-        recordUpdate(storage, success, relaxUpdates);
+        recordUpdate(storage, webApkInstallResult, relaxUpdates);
     }
 
     private static native void nativeUpdateAsync(String id, String startUrl, String scope,
             String name, String shortName, String bestIconUrl, Bitmap bestIcon, String[] iconUrls,
             String[] iconHashes, int displayMode, int orientation, long themeColor,
             long backgroundColor, String manifestUrl, String webApkPackage, int webApkVersion,
             boolean isManifestStale);
 }