Handlify GetPropertyWithCallback.

Handlify GetPropertyWithCallback.

R=mstarzinger@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=17234

[Michael Starzinger, 2013-10-16 08:21:07]

LGTM (just one suggestive nit).

https://codereview.chromium.org/27335002/diff/3001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/27335002/diff/3001/src/objects.cc#newcode345
src/objects.cc:345: Handle<Object> JSObject::GetPropertyWithForeignCallback(
nit: Does this need to be a member method on JSObject at all? Maybe it makes
sense to make it just a static helper. Simplifies the API exposed through the
header.

[Yang, 2013-10-16 09:10:21]

On 2013/10/16 08:21:07, Michael Starzinger wrote:
> LGTM (just one suggestive nit).
> 
> https://codereview.chromium.org/27335002/diff/3001/src/objects.cc
> File src/objects.cc (right):
> 
> https://codereview.chromium.org/27335002/diff/3001/src/objects.cc#newcode345
> src/objects.cc:345: Handle<Object> JSObject::GetPropertyWithForeignCallback(
> nit: Does this need to be a member method on JSObject at all? Maybe it makes
> sense to make it just a static helper. Simplifies the API exposed through the
> header.

After what we talked about offline, there is no need to check for scheduled
exceptions after foreign callback. So I'm removing the function by inlining it.

[Yang, 2013-10-16 09:13:38]

Committed patchset #3 manually as r17234 (presubmit successful).