Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2733463003: [DevTools] Console should wait for the main target (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 var historyData = this._consoleHistorySetting.get(); 143 var historyData = this._consoleHistorySetting.get();
144 this._prompt.history().setHistoryData(historyData); 144 this._prompt.history().setHistoryData(historyData);
145 this._consoleHistoryAutocompleteChanged(); 145 this._consoleHistoryAutocompleteChanged();
146 146
147 this._updateFilterStatus(); 147 this._updateFilterStatus();
148 Common.moduleSetting('consoleTimestampsEnabled').addChangeListener(this._con soleTimestampsSettingChanged, this); 148 Common.moduleSetting('consoleTimestampsEnabled').addChangeListener(this._con soleTimestampsSettingChanged, this);
149 149
150 this._registerWithMessageSink(); 150 this._registerWithMessageSink();
151 SDK.targetManager.observeTargets(this); 151 SDK.targetManager.observeTargets(this);
152 152
153 this._initConsoleMessages();
154
155 UI.context.addFlavorChangeListener(SDK.ExecutionContext, this._executionCont extChanged, this); 153 UI.context.addFlavorChangeListener(SDK.ExecutionContext, this._executionCont extChanged, this);
156 154
157 this._messagesElement.addEventListener('mousedown', this._updateStickToBotto mOnMouseDown.bind(this), false); 155 this._messagesElement.addEventListener('mousedown', this._updateStickToBotto mOnMouseDown.bind(this), false);
158 this._messagesElement.addEventListener('mouseup', this._updateStickToBottomO nMouseUp.bind(this), false); 156 this._messagesElement.addEventListener('mouseup', this._updateStickToBottomO nMouseUp.bind(this), false);
159 this._messagesElement.addEventListener('mouseleave', this._updateStickToBott omOnMouseUp.bind(this), false); 157 this._messagesElement.addEventListener('mouseleave', this._updateStickToBott omOnMouseUp.bind(this), false);
160 this._messagesElement.addEventListener('wheel', this._updateStickToBottomOnW heel.bind(this), false); 158 this._messagesElement.addEventListener('wheel', this._updateStickToBottomOnW heel.bind(this), false);
161 } 159 }
162 160
163 /** 161 /**
164 * @return {!Console.ConsoleView} 162 * @return {!Console.ConsoleView}
(...skipping 20 matching lines...) Expand all
185 183
186 _clearHistory() { 184 _clearHistory() {
187 this._consoleHistorySetting.set([]); 185 this._consoleHistorySetting.set([]);
188 this._prompt.history().setHistoryData([]); 186 this._prompt.history().setHistoryData([]);
189 } 187 }
190 188
191 _consoleHistoryAutocompleteChanged() { 189 _consoleHistoryAutocompleteChanged() {
192 this._prompt.setAddCompletionsFromHistory(this._consoleHistoryAutocompleteSe tting.get()); 190 this._prompt.setAddCompletionsFromHistory(this._consoleHistoryAutocompleteSe tting.get());
193 } 191 }
194 192
195 _initConsoleMessages() { 193 /**
196 var mainTarget = SDK.targetManager.mainTarget(); 194 * @param {!SDK.Target} target
197 var resourceTreeModel = mainTarget && SDK.ResourceTreeModel.fromTarget(mainT arget); 195 */
198 var resourcesLoaded = !resourceTreeModel || resourceTreeModel.cachedResource sLoaded(); 196 _initConsoleMessages(target) {
199 if (!mainTarget || !resourcesLoaded) { 197 var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target);
200 SDK.targetManager.addModelListener( 198 if (resourceTreeModel && !resourceTreeModel.cachedResourcesLoaded()) {
201 SDK.ResourceTreeModel, SDK.ResourceTreeModel.Events.CachedResourcesLoa ded, this._onResourceTreeModelLoaded, 199 resourceTreeModel.addEventListener(
202 this); 200 SDK.ResourceTreeModel.Events.CachedResourcesLoaded, this._onResourceTr eeModelLoaded, this);
203 return; 201 return;
204 } 202 }
205 this._fetchMultitargetMessages(); 203 this._fetchMultitargetMessages();
206 } 204 }
207 205
208 /** 206 /**
209 * @param {!Common.Event} event 207 * @param {!Common.Event} event
210 */ 208 */
211 _onResourceTreeModelLoaded(event) { 209 _onResourceTreeModelLoaded(event) {
212 var resourceTreeModel = /** @type {!SDK.ResourceTreeModel} */ (event.data); 210 var resourceTreeModel = /** @type {!SDK.ResourceTreeModel} */ (event.data);
213 if (resourceTreeModel.target() !== SDK.targetManager.mainTarget()) 211 resourceTreeModel.removeEventListener(
214 return; 212 SDK.ResourceTreeModel.Events.CachedResourcesLoaded, this._onResourceTree ModelLoaded, this);
215 SDK.targetManager.removeModelListener(
216 SDK.ResourceTreeModel, SDK.ResourceTreeModel.Events.CachedResourcesLoade d, this._onResourceTreeModelLoaded,
217 this);
218 this._fetchMultitargetMessages(); 213 this._fetchMultitargetMessages();
219 } 214 }
220 215
221 _fetchMultitargetMessages() { 216 _fetchMultitargetMessages() {
222 SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.Console Cleared, this._consoleCleared, this); 217 SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.Console Cleared, this._consoleCleared, this);
223 SDK.multitargetConsoleModel.addEventListener( 218 SDK.multitargetConsoleModel.addEventListener(
224 SDK.ConsoleModel.Events.MessageAdded, this._onConsoleMessageAdded, this) ; 219 SDK.ConsoleModel.Events.MessageAdded, this._onConsoleMessageAdded, this) ;
225 SDK.multitargetConsoleModel.addEventListener( 220 SDK.multitargetConsoleModel.addEventListener(
226 SDK.ConsoleModel.Events.MessageUpdated, this._onConsoleMessageUpdated, t his); 221 SDK.ConsoleModel.Events.MessageUpdated, this._onConsoleMessageUpdated, t his);
227 SDK.multitargetConsoleModel.addEventListener( 222 SDK.multitargetConsoleModel.addEventListener(
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 */ 257 */
263 minimumRowHeight() { 258 minimumRowHeight() {
264 return 16; 259 return 16;
265 } 260 }
266 261
267 /** 262 /**
268 * @override 263 * @override
269 * @param {!SDK.Target} target 264 * @param {!SDK.Target} target
270 */ 265 */
271 targetAdded(target) { 266 targetAdded(target) {
267 if (target === SDK.targetManager.mainTarget())
268 this._initConsoleMessages(target);
272 this._viewport.invalidate(); 269 this._viewport.invalidate();
273 this._updateAllMessagesCheckbox(); 270 this._updateAllMessagesCheckbox();
274 } 271 }
275 272
276 /** 273 /**
277 * @override 274 * @override
278 * @param {!SDK.Target} target 275 * @param {!SDK.Target} target
279 */ 276 */
280 targetRemoved(target) { 277 targetRemoved(target) {
281 this._updateAllMessagesCheckbox(); 278 this._updateAllMessagesCheckbox();
(...skipping 1051 matching lines...) Expand 10 before | Expand all | Expand 10 after
1333 return true; 1330 return true;
1334 } 1331 }
1335 return false; 1332 return false;
1336 } 1333 }
1337 }; 1334 };
1338 1335
1339 /** 1336 /**
1340 * @typedef {{messageIndex: number, matchIndex: number}} 1337 * @typedef {{messageIndex: number, matchIndex: number}}
1341 */ 1338 */
1342 Console.ConsoleView.RegexMatchRange; 1339 Console.ConsoleView.RegexMatchRange;
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698