Support DevFS paths encoded as URIs

Support DevFS paths encoded as URIs

Fixes #28972

Note that the path handling logic in DevFS is now complicated with three
possible sources of path information. After we roll this we should clean it
up and unify on Uri encoding

BUG=
R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/5128636521144814ebcb70d49c00fe1466583e0f

[Cutch, 2017-03-08 19:21:13]

Description was changed from

==========
Support DevFS paths encoded as URIs

Fixes #28972

Note that the path handling logic in DevFS is now complicated with three
possible sources of path information. After we roll this we should clean it
up and unify on Uri encoding

BUG=
==========

to

==========
Support DevFS paths encoded as URIs

Fixes #28972

Note that the path handling logic in DevFS is now complicated with three
possible sources of path information. After we roll this we should clean it
up and unify on Uri encoding

BUG=
==========

[Cutch, 2017-03-08 19:21:14]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[turnidge, 2017-03-08 21:13:51]

lgtm

https://codereview.chromium.org/2733413003/diff/1/sdk/lib/vmservice/devfs.dart
File sdk/lib/vmservice/devfs.dart (right):

https://codereview.chromium.org/2733413003/diff/1/sdk/lib/vmservice/devfs.dar...
sdk/lib/vmservice/devfs.dart:319: }
Does this code duplicate the code above?  Can there be a helper function?

[Cutch, 2017-03-08 23:41:07]

https://codereview.chromium.org/2733413003/diff/1/sdk/lib/vmservice/devfs.dart
File sdk/lib/vmservice/devfs.dart (right):

https://codereview.chromium.org/2733413003/diff/1/sdk/lib/vmservice/devfs.dar...
sdk/lib/vmservice/devfs.dart:319: }
On 2017/03/08 21:13:51, turnidge wrote:
> Does this code duplicate the code above?  Can there be a helper function?

A helper function is awkward here (see other DevFS methods that have duplicated
code) because of how errors are returned. Once Flutter integrates this we can
drop a bunch of the code.

[Cutch, 2017-03-08 23:41:17]

Description was changed from

==========
Support DevFS paths encoded as URIs

Fixes #28972

Note that the path handling logic in DevFS is now complicated with three
possible sources of path information. After we roll this we should clean it
up and unify on Uri encoding

BUG=
==========

to

==========
Support DevFS paths encoded as URIs

Fixes #28972

Note that the path handling logic in DevFS is now complicated with three
possible sources of path information. After we roll this we should clean it
up and unify on Uri encoding

BUG=
R=turnidge@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5128636521144814ebcb70d49c00fe1466583e0f
==========

[Cutch, 2017-03-08 23:41:25]

Committed patchset #1 (id:1) manually as
5128636521144814ebcb70d49c00fe1466583e0f (presubmit successful).