Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1671)

Unified Diff: chrome/browser/net/sdch_browsertest.cc

Issue 2733393003: Split browsing data masks between content and embedder (Closed)
Patch Set: Extensions can't match extensions if there are no extensions. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/sdch_browsertest.cc
diff --git a/chrome/browser/net/sdch_browsertest.cc b/chrome/browser/net/sdch_browsertest.cc
index 0966cc4e5c467a77336d63cd913742fdaeff08f0..f64a7ba619208ed2da8f6844edfb411246f00201 100644
--- a/chrome/browser/net/sdch_browsertest.cc
+++ b/chrome/browser/net/sdch_browsertest.cc
@@ -26,6 +26,7 @@
#include "chrome/browser/browsing_data/browsing_data_remover.h"
#include "chrome/browser/browsing_data/browsing_data_remover_factory.h"
#include "chrome/browser/browsing_data/browsing_data_remover_test_util.h"
+#include "chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/browser.h"
@@ -409,12 +410,14 @@ class SdchBrowserTest : public InProcessBrowserTest,
BrowsingDataRemover* remover =
BrowsingDataRemoverFactory::GetForBrowserContext(browser()->profile());
BrowsingDataRemoverCompletionObserver completion_observer(remover);
- remover->RemoveAndReply(browsing_data::CalculateBeginDeleteTime(
- browsing_data::TimePeriod::LAST_HOUR),
- browsing_data::CalculateEndDeleteTime(
- browsing_data::TimePeriod::LAST_HOUR),
- remove_mask, BrowsingDataHelper::UNPROTECTED_WEB,
- &completion_observer);
+ remover->RemoveAndReply(
+ browsing_data::CalculateBeginDeleteTime(
+ browsing_data::TimePeriod::LAST_HOUR),
+ browsing_data::CalculateEndDeleteTime(
+ browsing_data::TimePeriod::LAST_HOUR),
+ remove_mask,
+ ChromeBrowsingDataRemoverDelegate::ORIGIN_TYPE_UNPROTECTED_WEB,
+ &completion_observer);
completion_observer.BlockUntilCompletion();
}
@@ -676,14 +679,15 @@ IN_PROC_BROWSER_TEST_F(SdchBrowserTest, BrowsingDataRemover) {
// Confirm browsing data remover without removing the cache leaves
// SDCH alone.
- BrowsingDataRemoveAndWait(BrowsingDataRemover::REMOVE_ALL &
- ~BrowsingDataRemover::REMOVE_CACHE);
+ BrowsingDataRemoveAndWait(
+ ChromeBrowsingDataRemoverDelegate::ALL_DATA_TYPES &
+ ~ChromeBrowsingDataRemoverDelegate::DATA_TYPE_CACHE);
bool sdch_encoding_used = false;
ASSERT_TRUE(GetData(&sdch_encoding_used));
EXPECT_TRUE(sdch_encoding_used);
// Confirm browsing data remover removing the cache clears SDCH state.
- BrowsingDataRemoveAndWait(BrowsingDataRemover::REMOVE_CACHE);
+ BrowsingDataRemoveAndWait(ChromeBrowsingDataRemoverDelegate::DATA_TYPE_CACHE);
sdch_encoding_used = false;
ASSERT_TRUE(GetData(&sdch_encoding_used));
EXPECT_FALSE(sdch_encoding_used);

Powered by Google App Engine
This is Rietveld 408576698