Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2226)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_browsertest.cc

Issue 2733393003: Split browsing data masks between content and embedder (Closed)
Patch Set: Extensions can't match extensions if there are no extensions. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc b/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
index cdde107acf5150318ad758bb1e6027ee61d0798e..0e2384cb1906b7b77d9234f1a13b6776a3193d83 100644
--- a/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
@@ -15,6 +15,7 @@
#include "chrome/browser/browsing_data/browsing_data_remover_factory.h"
#include "chrome/browser/browsing_data/browsing_data_remover_test_util.h"
#include "chrome/browser/browsing_data/cache_counter.h"
+#include "chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/external_protocol/external_protocol_handler.h"
#include "chrome/browser/profiles/profile.h"
@@ -120,7 +121,8 @@ class BrowsingDataRemoverBrowserTest : public InProcessBrowserTest {
BrowsingDataRemoverCompletionObserver completion_observer(remover);
remover->RemoveAndReply(
base::Time(), base::Time::Max(), remove_mask,
- BrowsingDataHelper::UNPROTECTED_WEB, &completion_observer);
+ ChromeBrowsingDataRemoverDelegate::ORIGIN_TYPE_UNPROTECTED_WEB,
+ &completion_observer);
completion_observer.BlockUntilCompletion();
}
@@ -132,7 +134,8 @@ class BrowsingDataRemoverBrowserTest : public InProcessBrowserTest {
BrowsingDataRemoverCompletionObserver completion_observer(remover);
remover->RemoveWithFilterAndReply(
base::Time(), base::Time::Max(), remove_mask,
- BrowsingDataHelper::UNPROTECTED_WEB, std::move(filter_builder),
+ ChromeBrowsingDataRemoverDelegate::ORIGIN_TYPE_UNPROTECTED_WEB,
+ std::move(filter_builder),
&completion_observer);
completion_observer.BlockUntilCompletion();
}
@@ -194,7 +197,7 @@ class BrowsingDataRemoverTransportSecurityStateBrowserTest
// Test BrowsingDataRemover for downloads.
IN_PROC_BROWSER_TEST_F(BrowsingDataRemoverBrowserTest, Download) {
DownloadAnItem();
- RemoveAndWait(BrowsingDataRemover::REMOVE_DOWNLOADS);
+ RemoveAndWait(ChromeBrowsingDataRemoverDelegate::DATA_TYPE_DOWNLOADS);
VerifyDownloadCount(0u);
}
@@ -208,7 +211,7 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataRemoverBrowserTest, DownloadProhibited) {
prefs->SetBoolean(prefs::kAllowDeletingBrowserHistory, false);
DownloadAnItem();
- RemoveAndWait(BrowsingDataRemover::REMOVE_DOWNLOADS);
+ RemoveAndWait(ChromeBrowsingDataRemoverDelegate::DATA_TYPE_DOWNLOADS);
VerifyDownloadCount(1u);
}
#endif
@@ -223,7 +226,7 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataRemoverBrowserTest, Database) {
RunScriptAndCheckResult("insertRecord('text')", "done");
RunScriptAndCheckResult("getRecords()", "text");
- RemoveAndWait(BrowsingDataRemover::REMOVE_SITE_DATA);
+ RemoveAndWait(ChromeBrowsingDataRemoverDelegate::DATA_TYPE_SITE_DATA);
ui_test_utils::NavigateToURL(browser(), url);
RunScriptAndCheckResult("createTable()", "done");
@@ -254,7 +257,7 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataRemoverBrowserTest, Cache) {
std::unique_ptr<BrowsingDataFilterBuilder> filter_builder =
BrowsingDataFilterBuilder::Create(BrowsingDataFilterBuilder::WHITELIST);
filter_builder->AddOrigin(url::Origin(url1));
- RemoveWithFilterAndWait(BrowsingDataRemover::REMOVE_CACHE,
+ RemoveWithFilterAndWait(ChromeBrowsingDataRemoverDelegate::DATA_TYPE_CACHE,
std::move(filter_builder));
// After the partial deletion, the cache should be smaller but still nonempty.
@@ -265,12 +268,12 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataRemoverBrowserTest, Cache) {
filter_builder =
BrowsingDataFilterBuilder::Create(BrowsingDataFilterBuilder::WHITELIST);
filter_builder->AddOrigin(url::Origin(url1));
- RemoveWithFilterAndWait(BrowsingDataRemover::REMOVE_CACHE,
+ RemoveWithFilterAndWait(ChromeBrowsingDataRemoverDelegate::DATA_TYPE_CACHE,
std::move(filter_builder));
EXPECT_EQ(new_size, GetCacheSize());
// Delete the remaining data.
- RemoveAndWait(BrowsingDataRemover::REMOVE_CACHE);
+ RemoveAndWait(ChromeBrowsingDataRemoverDelegate::DATA_TYPE_CACHE);
// The cache is empty.
EXPECT_EQ(0, GetCacheSize());
@@ -285,7 +288,7 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataRemoverBrowserTest,
ExternalProtocolHandler::BlockState block_state =
ExternalProtocolHandler::GetBlockState("tel", profile);
ASSERT_EQ(ExternalProtocolHandler::BLOCK, block_state);
- RemoveAndWait(BrowsingDataRemover::REMOVE_SITE_DATA);
+ RemoveAndWait(ChromeBrowsingDataRemoverDelegate::DATA_TYPE_SITE_DATA);
block_state = ExternalProtocolHandler::GetBlockState("tel", profile);
ASSERT_EQ(ExternalProtocolHandler::UNKNOWN, block_state);
}
@@ -293,7 +296,7 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataRemoverBrowserTest,
// Verify that TransportSecurityState data is cleared for REMOVE_CACHE.
IN_PROC_BROWSER_TEST_F(BrowsingDataRemoverTransportSecurityStateBrowserTest,
ClearTransportSecurityState) {
- RemoveAndWait(BrowsingDataRemover::REMOVE_CACHE);
+ RemoveAndWait(ChromeBrowsingDataRemoverDelegate::DATA_TYPE_CACHE);
base::RunLoop run_loop;
BrowserThread::PostTaskAndReply(
BrowserThread::IO, FROM_HERE,
@@ -309,7 +312,7 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataRemoverTransportSecurityStateBrowserTest,
// set.
IN_PROC_BROWSER_TEST_F(BrowsingDataRemoverTransportSecurityStateBrowserTest,
PreserveTransportSecurityState) {
- RemoveAndWait(BrowsingDataRemover::REMOVE_SITE_DATA);
+ RemoveAndWait(ChromeBrowsingDataRemoverDelegate::DATA_TYPE_SITE_DATA);
base::RunLoop run_loop;
BrowserThread::PostTaskAndReply(
BrowserThread::IO, FROM_HERE,

Powered by Google App Engine
This is Rietveld 408576698