Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2733353002: Remove U+180E from whitespace in js_runtime and tests (Closed)

Created:
3 years, 9 months ago by sra1
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : strong tests #

Patch Set 3 : Update expected .status file changes #

Patch Set 4 : status #

Patch Set 5 : also corelib_strong #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -37 lines) Patch
M sdk/lib/_internal/js_runtime/lib/js_string.dart View 2 chunks +1 line, -3 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 3 5 chunks +11 lines, -10 lines 0 comments Download
M tests/corelib/double_parse_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/corelib/num_parse_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/corelib/string_trim2_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/corelib/string_trimlr_test.dart View 1 2 3 3 chunks +17 lines, -9 lines 0 comments Download
M tests/corelib_strong/double_parse_test.dart View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M tests/corelib_strong/int_parse_radix_test.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/num_parse_test.dart View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M tests/corelib_strong/string_trim2_test.dart View 1 1 chunk +0 lines, -1 line 1 comment Download
M tests/corelib_strong/string_trimlr_test.dart View 1 2 chunks +1 line, -3 lines 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M tests/lib/math/math_parse_double_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib_strong/math/math_parse_double_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
sra1
3 years, 9 months ago (2017-03-13 23:29:07 UTC) #3
Alan Knight
LGTM , but should we update status files for Firefox?
3 years, 9 months ago (2017-03-13 23:35:38 UTC) #4
vsm
On 2017/03/13 23:35:38, Alan Knight wrote: > LGTM , but should we update status files ...
3 years, 9 months ago (2017-03-13 23:43:22 UTC) #5
sra1
Committed patchset #5 (id:80001) manually as c6a01283c1d8012648a22b317aa3fd0fe64f2aff (presubmit successful).
3 years, 9 months ago (2017-03-14 03:18:34 UTC) #7
Lasse Reichstein Nielsen
3 years, 9 months ago (2017-03-14 08:21:17 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/2733353002/diff/80001/tests/corelib_strong/st...
File tests/corelib_strong/string_trim2_test.dart (right):

https://codereview.chromium.org/2733353002/diff/80001/tests/corelib_strong/st...
tests/corelib_strong/string_trim2_test.dart:47: Expect.equals("", new
String.fromCharCodes(WHITESPACE).trim(), "ALL");
As a regression test, we should check that U+180E is *not* removed by trim. That
will fail in browsers where it still is removed.

Powered by Google App Engine
This is Rietveld 408576698