Chromium Code Reviews Chromium Code Reviews
Issue 2733343002:
Move chrome/common/safe_browsing/csd.proto to components/safe_browsing (Closed)
| OLD | NEW |
|---|---|
| 1 include_rules = [ | 1 include_rules = [ |
| 2 "+chrome/grit", | 2 "+chrome/grit", |
| 3 "+chrome/install_static", | 3 "+chrome/install_static", |
| 4 "+chromeos", # For chromeos_switches.h | 4 "+chromeos", # For chromeos_switches.h |
| 5 "+components/autofill/content/common", | 5 "+components/autofill/content/common", |
| 6 "+components/autofill/core/common", | 6 "+components/autofill/core/common", |
| 7 "+components/bookmarks/common", | 7 "+components/bookmarks/common", |
| 8 "+components/cast_certificate", | 8 "+components/cast_certificate", |
| 9 "+components/cdm/common", | 9 "+components/cdm/common", |
| 10 "+components/cloud_devices/common", | 10 "+components/cloud_devices/common", |
| 11 "+components/content_settings/core/common", | 11 "+components/content_settings/core/common", |
| 12 "+components/crash/core/common", | 12 "+components/crash/core/common", |
| 13 "+components/crx_file", | 13 "+components/crx_file", |
| 14 "+components/data_reduction_proxy/core/common", | 14 "+components/data_reduction_proxy/core/common", |
| 15 "+components/dom_distiller/core", | 15 "+components/dom_distiller/core", |
| 16 "+components/flags_ui/flags_ui_switches.h", | 16 "+components/flags_ui/flags_ui_switches.h", |
| 17 "+components/gcm_driver", | 17 "+components/gcm_driver", |
| 18 "+components/metrics/client_info.h", | 18 "+components/metrics/client_info.h", |
| 19 "+components/metrics/metrics_pref_names.h", | 19 "+components/metrics/metrics_pref_names.h", |
| 20 "+components/nacl/common", | 20 "+components/nacl/common", |
| 21 "+components/ntp_tiles", | 21 "+components/ntp_tiles", |
| 22 "+components/offline_pages/offline_page_feature.h", | 22 "+components/offline_pages/offline_page_feature.h", |
| 23 "+components/password_manager/core/common", | 23 "+components/password_manager/core/common", |
| 24 "+components/policy/core/common", | 24 "+components/policy/core/common", |
| 25 "+components/printing/common", | 25 "+components/printing/common", |
| 26 "+components/safe_browsing/csd.pb.h", | |
|
Nathan Parker
2017/03/08 17:31:43
This seems rather specific for what's otherwise a
Jialiu Lin
2017/03/08 18:31:33
chrome/common folder does not need components/safe
| |
| 26 "+components/signin/core/common", | 27 "+components/signin/core/common", |
| 27 "+components/translate/core/common", | 28 "+components/translate/core/common", |
| 28 "+components/url_formatter", | 29 "+components/url_formatter", |
| 29 "+components/version_info", | 30 "+components/version_info", |
| 30 "+extensions/common", | 31 "+extensions/common", |
| 31 "+extensions/features", | 32 "+extensions/features", |
| 32 "+gin/public", # For profiling.cc | 33 "+gin/public", # For profiling.cc |
| 33 "+google_apis/gaia", # For gaia_switches.h | 34 "+google_apis/gaia", # For gaia_switches.h |
| 34 "+media", | 35 "+media", |
| 35 "+ppapi/c", | 36 "+ppapi/c", |
| 36 "+ppapi/shared_impl", | 37 "+ppapi/shared_impl", |
| 37 "+ppapi/thunk", | 38 "+ppapi/thunk", |
| 38 "+rlz/features/features.h", | 39 "+rlz/features/features.h", |
| 39 "+sandbox/linux/services/credentials.h", | 40 "+sandbox/linux/services/credentials.h", |
| 40 "+third_party/boringssl/src/include", | 41 "+third_party/boringssl/src/include", |
| 41 | 42 |
| 42 # FIXME - refactor code and remove these dependencies | 43 # FIXME - refactor code and remove these dependencies |
| 43 "+chrome/installer", | 44 "+chrome/installer", |
| 44 ] | 45 ] |
| 45 specific_include_rules = { | 46 specific_include_rules = { |
| 46 "service_process_util.*": [ | 47 "service_process_util.*": [ |
| 47 "+mojo/edk/embedder", | 48 "+mojo/edk/embedder", |
| 48 ], | 49 ], |
| 49 } | 50 } |
| OLD | NEW |
