Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: sandbox/mac/sandbox_mac_compiler_unittest.mm

Issue 2733323002: Changing multiprocess test SpawnChild to return a struct. (Closed)
Patch Set: Synced Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/mac/bootstrap_sandbox_unittest.mm ('k') | sandbox/mac/sandbox_mac_compiler_v2_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/mac/sandbox_mac_compiler_unittest.mm
diff --git a/sandbox/mac/sandbox_mac_compiler_unittest.mm b/sandbox/mac/sandbox_mac_compiler_unittest.mm
index 404bf4bbabb9e8d2bcb0ed491c95c8063de98a64..0e9ee97c739c5cfa99bcbdb3cf261bbe14b52b36 100644
--- a/sandbox/mac/sandbox_mac_compiler_unittest.mm
+++ b/sandbox/mac/sandbox_mac_compiler_unittest.mm
@@ -32,11 +32,11 @@ MULTIPROCESS_TEST_MAIN(BasicProfileProcess) {
}
TEST_F(SandboxMacCompilerTest, BasicProfileTest) {
- base::Process process = SpawnChild("BasicProfileProcess");
- ASSERT_TRUE(process.IsValid());
+ base::SpawnChildResult spawn_child = SpawnChild("BasicProfileProcess");
+ ASSERT_TRUE(spawn_child.process.IsValid());
int exit_code = 42;
- EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
- &exit_code));
+ EXPECT_TRUE(spawn_child.process.WaitForExitWithTimeout(
+ TestTimeouts::action_max_timeout(), &exit_code));
EXPECT_EQ(exit_code, 0);
}
@@ -55,11 +55,12 @@ MULTIPROCESS_TEST_MAIN(BasicProfileWithParamProcess) {
}
TEST_F(SandboxMacCompilerTest, BasicProfileTestWithParam) {
- base::Process process = SpawnChild("BasicProfileWithParamProcess");
- ASSERT_TRUE(process.IsValid());
+ base::SpawnChildResult spawn_child =
+ SpawnChild("BasicProfileWithParamProcess");
+ ASSERT_TRUE(spawn_child.process.IsValid());
int exit_code = 42;
- EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
- &exit_code));
+ EXPECT_TRUE(spawn_child.process.WaitForExitWithTimeout(
+ TestTimeouts::action_max_timeout(), &exit_code));
EXPECT_EQ(exit_code, 0);
}
@@ -86,11 +87,11 @@ MULTIPROCESS_TEST_MAIN(ProfileFunctionalProcess) {
}
TEST_F(SandboxMacCompilerTest, ProfileFunctionalityTest) {
- base::Process process = SpawnChild("ProfileFunctionalProcess");
- ASSERT_TRUE(process.IsValid());
+ base::SpawnChildResult spawn_child = SpawnChild("ProfileFunctionalProcess");
+ ASSERT_TRUE(spawn_child.process.IsValid());
int exit_code = 42;
- EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
- &exit_code));
+ EXPECT_TRUE(spawn_child.process.WaitForExitWithTimeout(
+ TestTimeouts::action_max_timeout(), &exit_code));
EXPECT_EQ(exit_code, 0);
}
@@ -126,11 +127,12 @@ MULTIPROCESS_TEST_MAIN(ProfileFunctionalTestWithParamsProcess) {
}
TEST_F(SandboxMacCompilerTest, ProfileFunctionalityTestWithParams) {
- base::Process process = SpawnChild("ProfileFunctionalTestWithParamsProcess");
- ASSERT_TRUE(process.IsValid());
+ base::SpawnChildResult spawn_child =
+ SpawnChild("ProfileFunctionalTestWithParamsProcess");
+ ASSERT_TRUE(spawn_child.process.IsValid());
int exit_code = 42;
- EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
- &exit_code));
+ EXPECT_TRUE(spawn_child.process.WaitForExitWithTimeout(
+ TestTimeouts::action_max_timeout(), &exit_code));
EXPECT_EQ(exit_code, 0);
}
@@ -149,11 +151,12 @@ MULTIPROCESS_TEST_MAIN(ProfileFunctionalityTestErrorProcess) {
}
TEST_F(SandboxMacCompilerTest, ProfileFunctionalityTestError) {
- base::Process process = SpawnChild("ProfileFunctionalityTestErrorProcess");
- ASSERT_TRUE(process.IsValid());
+ base::SpawnChildResult spawn_child =
+ SpawnChild("ProfileFunctionalityTestErrorProcess");
+ ASSERT_TRUE(spawn_child.process.IsValid());
int exit_code = 42;
- EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
- &exit_code));
+ EXPECT_TRUE(spawn_child.process.WaitForExitWithTimeout(
+ TestTimeouts::action_max_timeout(), &exit_code));
EXPECT_EQ(exit_code, 0);
}
« no previous file with comments | « sandbox/mac/bootstrap_sandbox_unittest.mm ('k') | sandbox/mac/sandbox_mac_compiler_v2_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698