Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: mojo/edk/test/multiprocess_test_helper.cc

Issue 2733323002: Changing multiprocess test SpawnChild to return a struct. (Closed)
Patch Set: Synced Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/test/multiprocess_test_helper.h ('k') | sandbox/mac/bootstrap_sandbox_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/test/multiprocess_test_helper.cc
diff --git a/mojo/edk/test/multiprocess_test_helper.cc b/mojo/edk/test/multiprocess_test_helper.cc
index de6e2d9df676202f7de8fe6cf507c83d6200da81..4bc550f505e2424f62229ace819c41d4dd4932e8 100644
--- a/mojo/edk/test/multiprocess_test_helper.cc
+++ b/mojo/edk/test/multiprocess_test_helper.cc
@@ -58,7 +58,7 @@ int RunClientFunction(Func handler) {
MultiprocessTestHelper::MultiprocessTestHelper() {}
MultiprocessTestHelper::~MultiprocessTestHelper() {
- CHECK(!test_child_.IsValid());
+ CHECK(!test_child_.process.IsValid());
}
ScopedMessagePipeHandle MultiprocessTestHelper::StartChild(
@@ -74,7 +74,7 @@ ScopedMessagePipeHandle MultiprocessTestHelper::StartChildWithExtraSwitch(
const std::string& switch_value,
LaunchType launch_type) {
CHECK(!test_child_name.empty());
- CHECK(!test_child_.IsValid());
+ CHECK(!test_child_.process.IsValid());
std::string test_child_main = test_child_name + "TestChildMain";
@@ -168,22 +168,22 @@ ScopedMessagePipeHandle MultiprocessTestHelper::StartChildWithExtraSwitch(
if (launch_type == LaunchType::CHILD ||
launch_type == LaunchType::NAMED_CHILD) {
DCHECK(server_handle.is_valid());
- process.Connect(test_child_.Handle(),
+ process.Connect(test_child_.process.Handle(),
ConnectionParams(std::move(server_handle)),
process_error_callback_);
}
- CHECK(test_child_.IsValid());
+ CHECK(test_child_.process.IsValid());
return pipe;
}
int MultiprocessTestHelper::WaitForChildShutdown() {
- CHECK(test_child_.IsValid());
+ CHECK(test_child_.process.IsValid());
int rv = -1;
- WaitForMultiprocessTestChildExit(test_child_, TestTimeouts::action_timeout(),
- &rv);
- test_child_.Close();
+ WaitForMultiprocessTestChildExit(test_child_.process,
+ TestTimeouts::action_timeout(), &rv);
+ test_child_.process.Close();
return rv;
}
« no previous file with comments | « mojo/edk/test/multiprocess_test_helper.h ('k') | sandbox/mac/bootstrap_sandbox_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698