Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: base/debug/stack_trace_unittest.cc

Issue 2733323002: Changing multiprocess test SpawnChild to return a struct. (Closed)
Patch Set: Synced Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/files/file_locking_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/stack_trace_unittest.cc
diff --git a/base/debug/stack_trace_unittest.cc b/base/debug/stack_trace_unittest.cc
index 560dc1ddde8dc5ee7dd42e62b0e0e296ad5a5ac4..bbcf388376a602733519d3100cdeb761ffb3bcce 100644
--- a/base/debug/stack_trace_unittest.cc
+++ b/base/debug/stack_trace_unittest.cc
@@ -171,11 +171,11 @@ MULTIPROCESS_TEST_MAIN(MismatchedMallocChildProcess) {
// and e.g. mismatched new[]/delete would cause a hang because
// of re-entering malloc.
TEST_F(StackTraceTest, AsyncSignalUnsafeSignalHandlerHang) {
- Process child = SpawnChild("MismatchedMallocChildProcess");
- ASSERT_TRUE(child.IsValid());
+ SpawnChildResult spawn_result = SpawnChild("MismatchedMallocChildProcess");
+ ASSERT_TRUE(spawn_result.process.IsValid());
int exit_code;
- ASSERT_TRUE(child.WaitForExitWithTimeout(TestTimeouts::action_timeout(),
- &exit_code));
+ ASSERT_TRUE(spawn_result.process.WaitForExitWithTimeout(
+ TestTimeouts::action_timeout(), &exit_code));
}
#endif // !defined(OS_IOS)
« no previous file with comments | « no previous file | base/files/file_locking_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698