Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: content/common/sandbox_mac_unittest_helper.mm

Issue 2733323002: Changing multiprocess test SpawnChild to return a struct. (Closed)
Patch Set: Fix Windows build. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/sandbox_mac_unittest_helper.mm
diff --git a/content/common/sandbox_mac_unittest_helper.mm b/content/common/sandbox_mac_unittest_helper.mm
index 5988ffe6cfa0d77ebb63e95bb6fd52d0369b981d..9d8ddd45afec3bc9656074f464b693962563bcee 100644
--- a/content/common/sandbox_mac_unittest_helper.mm
+++ b/content/common/sandbox_mac_unittest_helper.mm
@@ -77,13 +77,13 @@ bool MacSandboxTest::RunTestInSandbox(SandboxType sandbox_type,
if (test_data)
setenv(kTestDataKey, test_data, 1);
- base::Process child_process = SpawnChild("mac_sandbox_test_runner");
- if (!child_process.IsValid()) {
+ base::SpawnChildResult spawn_child = SpawnChild("mac_sandbox_test_runner");
+ if (!spawn_child.process.IsValid()) {
LOG(WARNING) << "SpawnChild failed";
return false;
}
int code = -1;
- if (!child_process.WaitForExit(&code)) {
+ if (!spawn_child.process.WaitForExit(&code)) {
LOG(WARNING) << "Process::WaitForExit failed";
return false;
}

Powered by Google App Engine
This is Rietveld 408576698