chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc - Issue 2733323002: Changing multiprocess test SpawnChild to return a struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

Issue 2733323002: Changing multiprocess test SpawnChild to return a struct. (Closed)

Patch Set: Fix Windows build. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/process/process_unittest.cc ('K') | « base/win/wait_chain_unittest.cc ('k') | chrome/browser/process_singleton_win_unittest.cc » ('j') | content/browser/memory/memory_coordinator_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

diff --git a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

index db561a302c06ec3dceb32bc5d8721f4046ea03cb..45617d6cff85241c5e1393b666988037402cab1c 100644

--- a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

+++ b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

@@ -470,9 +470,9 @@ base::Process CloudPrintProxyPolicyStartupTest::Launch(

.release(),

IPC::Channel::MODE_SERVER, this, IOTaskRunner());

- base::Process process = SpawnChild(name);

- EXPECT_TRUE(process.IsValid());

- return process;

+ base::SpawnChildResult spawn_result = SpawnChild(name);

+ EXPECT_TRUE(spawn_result.process.IsValid());

+ return std::move(spawn_result.process);

}

void CloudPrintProxyPolicyStartupTest::WaitForConnect() {