Changing multiprocess test SpawnChild to return a struct.

base/mac/mach_port_broker_unittest.cc

Index: base/mac/mach_port_broker_unittest.cc
diff --git a/base/mac/mach_port_broker_unittest.cc b/base/mac/mach_port_broker_unittest.cc
index bff8eb6a9bc946d9e46e04c007b7d8d52fbc66c2..076d26d7de65f56e54b9e55b680a41ed3e7dda81 100644
--- a/base/mac/mach_port_broker_unittest.cc
+++ b/base/mac/mach_port_broker_unittest.cc
@@ -95,8 +95,9 @@ TEST_F(MachPortBrokerTest, ReceivePortFromChild) {
   CommandLine command_line(
       base::GetMultiProcessTestChildBaseCommandLine());
   broker_.GetLock().Acquire();
-  base::Process test_child_process = base::SpawnMultiProcessTestChild(
+  base::SpawnChildResult spawn_result = base::SpawnMultiProcessTestChild(
       "MachPortBrokerTestChild", command_line, LaunchOptions());
+  base::Process test_child_process = std::move(spawn_result.process);

[dcheng, 2017/03/14 05:28:51]

I think this std::move is unnecessary. Maybe we can just  alias this into a
base::Process& to have a more convenient name.

[Jay Civelli, 2017/03/14 16:29:12]

It's short enough that I kept the full spawn_result.process.

   broker_.AddPlaceholderForPid(test_child_process.Handle());
   broker_.GetLock().Release();
 
@@ -117,8 +118,10 @@ TEST_F(MachPortBrokerTest, ReceivePortFromChildWithoutAdding) {
   CommandLine command_line(
       base::GetMultiProcessTestChildBaseCommandLine());
   broker_.GetLock().Acquire();
-  base::Process test_child_process = base::SpawnMultiProcessTestChild(
+  base::SpawnChildResult spawn_result = base::SpawnMultiProcessTestChild(
       "MachPortBrokerTestChild", command_line, LaunchOptions());
+  base::Process test_child_process = std::move(spawn_result.process);
+
   broker_.GetLock().Release();
 
   int rv = -1;