content/common/sandbox_mac_unittest_helper.mm - Issue 2733323002: Changing multiprocess test SpawnChild to return a struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/sandbox_mac_unittest_helper.mm

Issue 2733323002: Changing multiprocess test SpawnChild to return a struct. (Closed)

Patch Set: Fixed bots. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/sandbox_mac_unittest_helper.mm

diff --git a/content/common/sandbox_mac_unittest_helper.mm b/content/common/sandbox_mac_unittest_helper.mm

index 5988ffe6cfa0d77ebb63e95bb6fd52d0369b981d..b4b4a0abb89f19285cb453cc01ac78f123dbc52e 100644

--- a/content/common/sandbox_mac_unittest_helper.mm

+++ b/content/common/sandbox_mac_unittest_helper.mm

@@ -77,7 +77,8 @@ bool MacSandboxTest::RunTestInSandbox(SandboxType sandbox_type,

if (test_data)

setenv(kTestDataKey, test_data, 1);

- base::Process child_process = SpawnChild("mac_sandbox_test_runner");

+ base::SpawnChildResult spawn_result = SpawnChild("mac_sandbox_test_runner");

+ base::Process child_process = std::move(spawn_result.process);

if (!child_process.IsValid()) {

LOG(WARNING) << "SpawnChild failed";

return false;