base/memory/shared_memory_unittest.cc - Issue 2733323002: Changing multiprocess test SpawnChild to return a struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/shared_memory_unittest.cc

Issue 2733323002: Changing multiprocess test SpawnChild to return a struct. (Closed)

Patch Set: Fixed bots. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/shared_memory_unittest.cc

diff --git a/base/memory/shared_memory_unittest.cc b/base/memory/shared_memory_unittest.cc

index 19dedccb4768ad01040aa73a90d722e32fe18f8e..1ca2181c316a95b0189c5acef699726d9cff277e 100644

--- a/base/memory/shared_memory_unittest.cc

+++ b/base/memory/shared_memory_unittest.cc

@@ -684,7 +684,8 @@ TEST_F(SharedMemoryProcessTest, SharedMemoryAcrossProcesses) {

// word by 1.

Process processes[kNumTasks];

for (int index = 0; index < kNumTasks; ++index) {

- processes[index] = SpawnChild("SharedMemoryTestMain");

+ SpawnChildResult spawn_result = SpawnChild("SharedMemoryTestMain");

+ processes[index] = std::move(spawn_result.process);

ASSERT_TRUE(processes[index].IsValid());

}