Changing multiprocess test SpawnChild to return a struct.

content/browser/memory/memory_coordinator_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/memory/memory_coordinator_impl.h"
 
 #include "base/memory/memory_coordinator_client_registry.h"
 #include "base/memory/memory_coordinator_proxy.h"
 #include "base/memory/memory_pressure_monitor.h"
 #include "base/memory/ptr_util.h"
@@ skipping 514 matching lines @@
 #define MAYBE_GetStateForProcess GetStateForProcess
 #endif
 TEST_F(MemoryCoordinatorImplTest, MAYBE_GetStateForProcess) {
   EXPECT_EQ(base::MemoryState::UNKNOWN,
             coordinator_->GetStateForProcess(base::kNullProcessHandle));
   EXPECT_EQ(base::MemoryState::NORMAL,
             coordinator_->GetStateForProcess(base::GetCurrentProcessHandle()));
 
   coordinator_->CreateChildMemoryCoordinator(1);
   coordinator_->CreateChildMemoryCoordinator(2);
-  base::Process process1 = SpawnChild("process1");
-  base::Process process2 = SpawnChild("process2");
+
+  base::SpawnChildResult spawn_result = SpawnChild("process1");
+  base::Process process1 = std::move(spawn_result.process);
+  spawn_result = SpawnChild("process2");

[dcheng, 2017/03/14 05:28:51]

Maybe make this a separate spawn_result so this can also use the aliasing trick.

[Jay Civelli, 2017/03/14 16:29:12]

Good idea, done.

+  base::Process process2 = std::move(spawn_result.process);
+
   coordinator_->GetMockRenderProcessHost(1)->SetProcessHandle(
       base::MakeUnique<base::ProcessHandle>(process1.Handle()));
   coordinator_->GetMockRenderProcessHost(2)->SetProcessHandle(
       base::MakeUnique<base::ProcessHandle>(process2.Handle()));
 
   EXPECT_EQ(base::MemoryState::NORMAL,
             coordinator_->GetStateForProcess(process1.Handle()));
   EXPECT_EQ(base::MemoryState::NORMAL,
             coordinator_->GetStateForProcess(process2.Handle()));
 
   EXPECT_TRUE(
       coordinator_->SetChildMemoryState(1, MemoryState::THROTTLED));
   EXPECT_EQ(base::MemoryState::THROTTLED,
             coordinator_->GetStateForProcess(process1.Handle()));
   EXPECT_EQ(base::MemoryState::NORMAL,
             coordinator_->GetStateForProcess(process2.Handle()));
 }
 
 }  // namespace content