Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1947)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ash/common/wm/window_dimmer.cc

Issue 2733303004: Removes WmShell::NewWindow() (Closed)
Patch Set: merge and feedback Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/test/ash_test.cc ('k') | ash/common/wm/workspace/workspace_layout_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/wm/window_dimmer.cc
diff --git a/ash/common/wm/window_dimmer.cc b/ash/common/wm/window_dimmer.cc
index c90d806832fe21d6b24aa82e6689315fee2209f6..d5db58154f00bb0bb352df057d92eae911913fd9 100644
--- a/ash/common/wm/window_dimmer.cc
+++ b/ash/common/wm/window_dimmer.cc
@@ -24,8 +24,9 @@ const float kDefaultDimOpacity = 0.5f;
WindowDimmer::WindowDimmer(WmWindow* parent)
: parent_(parent),
- window_(WmShell::Get()->NewWindow(ui::wm::WINDOW_TYPE_NORMAL,
- ui::LAYER_SOLID_COLOR)) {
+ window_(WmWindow::Get(
+ new aura::Window(nullptr, ui::wm::WINDOW_TYPE_NORMAL))) {
+ window_->aura_window()->Init(ui::LAYER_SOLID_COLOR);
window_->SetVisibilityChangesAnimated();
window_->SetVisibilityAnimationType(
::wm::WINDOW_VISIBILITY_ANIMATION_TYPE_FADE);
« no previous file with comments | « ash/common/test/ash_test.cc ('k') | ash/common/wm/workspace/workspace_layout_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698