Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: ash/common/wm_shell.h

Issue 2733303004: Removes WmShell::NewWindow() (Closed)
Patch Set: merge and feedback Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_WM_SHELL_H_ 5 #ifndef ASH_COMMON_WM_SHELL_H_
6 #define ASH_COMMON_WM_SHELL_H_ 6 #define ASH_COMMON_WM_SHELL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
11 #include <vector> 11 #include <vector>
12 12
13 #include "ash/ash_export.h" 13 #include "ash/ash_export.h"
14 #include "ash/common/metrics/gesture_action_type.h" 14 #include "ash/common/metrics/gesture_action_type.h"
15 #include "ash/common/metrics/user_metrics_action.h" 15 #include "ash/common/metrics/user_metrics_action.h"
16 #include "ash/common/session/session_state_observer.h" 16 #include "ash/common/session/session_state_observer.h"
17 #include "ash/common/wm/lock_state_observer.h" 17 #include "ash/common/wm/lock_state_observer.h"
18 #include "base/observer_list.h" 18 #include "base/observer_list.h"
19 #include "components/ui_devtools/devtools_server.h" 19 #include "components/ui_devtools/devtools_server.h"
20 #include "ui/base/ui_base_types.h" 20 #include "ui/base/ui_base_types.h"
21 #include "ui/compositor/layer_type.h" 21 #include "ui/compositor/layer_type.h"
22 #include "ui/wm/public/activation_change_observer.h"
22 #include "ui/wm/public/window_types.h" 23 #include "ui/wm/public/window_types.h"
23 24
24 namespace app_list { 25 namespace app_list {
25 class AppList; 26 class AppList;
26 } 27 }
27 28
28 namespace base { 29 namespace base {
29 class SequencedWorkerPool; 30 class SequencedWorkerPool;
30 } 31 }
31 32
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 return window_selector_controller_.get(); 207 return window_selector_controller_.get();
207 } 208 }
208 209
209 const scoped_refptr<base::SequencedWorkerPool>& blocking_pool() { 210 const scoped_refptr<base::SequencedWorkerPool>& blocking_pool() {
210 return blocking_pool_; 211 return blocking_pool_;
211 } 212 }
212 213
213 // Returns true when ash is running as a service_manager::Service. 214 // Returns true when ash is running as a service_manager::Service.
214 virtual bool IsRunningInMash() const = 0; 215 virtual bool IsRunningInMash() const = 0;
215 216
216 virtual WmWindow* NewWindow(ui::wm::WindowType window_type,
217 ui::LayerType layer_type) = 0;
218
219 virtual WmWindow* GetFocusedWindow() = 0; 217 virtual WmWindow* GetFocusedWindow() = 0;
220 virtual WmWindow* GetActiveWindow() = 0; 218 virtual WmWindow* GetActiveWindow() = 0;
221 219
222 virtual WmWindow* GetCaptureWindow() = 0; 220 virtual WmWindow* GetCaptureWindow() = 0;
223 221
224 // Convenience for GetPrimaryRootWindow()->GetRootWindowController(). 222 // Convenience for GetPrimaryRootWindow()->GetRootWindowController().
225 RootWindowController* GetPrimaryRootWindowController(); 223 RootWindowController* GetPrimaryRootWindowController();
226 224
227 virtual WmWindow* GetPrimaryRootWindow() = 0; 225 virtual WmWindow* GetPrimaryRootWindow() = 0;
228 226
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 base::ObserverList<LockStateObserver> lock_state_observers_; 470 base::ObserverList<LockStateObserver> lock_state_observers_;
473 471
474 bool simulate_modal_window_open_for_testing_ = false; 472 bool simulate_modal_window_open_for_testing_ = false;
475 473
476 scoped_refptr<base::SequencedWorkerPool> blocking_pool_; 474 scoped_refptr<base::SequencedWorkerPool> blocking_pool_;
477 }; 475 };
478 476
479 } // namespace ash 477 } // namespace ash
480 478
481 #endif // ASH_COMMON_WM_SHELL_H_ 479 #endif // ASH_COMMON_WM_SHELL_H_
OLDNEW
« no previous file with comments | « ash/common/wm/workspace/workspace_layout_manager_unittest.cc ('k') | ash/common/wm_window_user_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698