Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Side by Side Diff: ash/common/wm_shell.h

Issue 2733303004: Removes WmShell::NewWindow() (Closed)
Patch Set: cleanup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_WM_SHELL_H_ 5 #ifndef ASH_COMMON_WM_SHELL_H_
6 #define ASH_COMMON_WM_SHELL_H_ 6 #define ASH_COMMON_WM_SHELL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
11 #include <vector> 11 #include <vector>
12 12
13 #include "ash/ash_export.h" 13 #include "ash/ash_export.h"
14 #include "ash/common/metrics/gesture_action_type.h" 14 #include "ash/common/metrics/gesture_action_type.h"
15 #include "ash/common/metrics/user_metrics_action.h" 15 #include "ash/common/metrics/user_metrics_action.h"
16 #include "ash/common/session/session_state_observer.h" 16 #include "ash/common/session/session_state_observer.h"
17 #include "ash/common/wm/lock_state_observer.h" 17 #include "ash/common/wm/lock_state_observer.h"
18 #include "base/observer_list.h" 18 #include "base/observer_list.h"
19 #include "components/ui_devtools/devtools_server.h" 19 #include "components/ui_devtools/devtools_server.h"
20 #include "ui/base/ui_base_types.h" 20 #include "ui/base/ui_base_types.h"
21 #include "ui/compositor/layer_type.h"
22 #include "ui/wm/public/activation_change_observer.h" 21 #include "ui/wm/public/activation_change_observer.h"
23 #include "ui/wm/public/window_types.h"
24 22
25 namespace app_list { 23 namespace app_list {
26 class AppList; 24 class AppList;
27 } 25 }
28 26
29 namespace base { 27 namespace base {
30 class SequencedWorkerPool; 28 class SequencedWorkerPool;
31 } 29 }
32 30
33 namespace display { 31 namespace display {
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 return window_selector_controller_.get(); 212 return window_selector_controller_.get();
215 } 213 }
216 214
217 const scoped_refptr<base::SequencedWorkerPool>& blocking_pool() { 215 const scoped_refptr<base::SequencedWorkerPool>& blocking_pool() {
218 return blocking_pool_; 216 return blocking_pool_;
219 } 217 }
220 218
221 // Returns true when ash is running as a service_manager::Service. 219 // Returns true when ash is running as a service_manager::Service.
222 virtual bool IsRunningInMash() const = 0; 220 virtual bool IsRunningInMash() const = 0;
223 221
224 virtual WmWindow* NewWindow(ui::wm::WindowType window_type,
225 ui::LayerType layer_type) = 0;
226
227 virtual WmWindow* GetFocusedWindow() = 0; 222 virtual WmWindow* GetFocusedWindow() = 0;
228 virtual WmWindow* GetActiveWindow() = 0; 223 virtual WmWindow* GetActiveWindow() = 0;
229 224
230 virtual WmWindow* GetCaptureWindow() = 0; 225 virtual WmWindow* GetCaptureWindow() = 0;
231 226
232 // Convenience for GetPrimaryRootWindow()->GetRootWindowController(). 227 // Convenience for GetPrimaryRootWindow()->GetRootWindowController().
233 RootWindowController* GetPrimaryRootWindowController(); 228 RootWindowController* GetPrimaryRootWindowController();
234 229
235 virtual WmWindow* GetPrimaryRootWindow() = 0; 230 virtual WmWindow* GetPrimaryRootWindow() = 0;
236 231
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
542 WmWindow* scoped_root_window_for_new_windows_ = nullptr; 537 WmWindow* scoped_root_window_for_new_windows_ = nullptr;
543 538
544 bool simulate_modal_window_open_for_testing_ = false; 539 bool simulate_modal_window_open_for_testing_ = false;
545 540
546 scoped_refptr<base::SequencedWorkerPool> blocking_pool_; 541 scoped_refptr<base::SequencedWorkerPool> blocking_pool_;
547 }; 542 };
548 543
549 } // namespace ash 544 } // namespace ash
550 545
551 #endif // ASH_COMMON_WM_SHELL_H_ 546 #endif // ASH_COMMON_WM_SHELL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698