Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: content/child/service_worker/service_worker_network_provider.h

Issue 2733283004: Expose WebServiceWorkerNetworkProvider on DataSource (Closed)
Patch Set: addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/service_worker_network_provider.h
diff --git a/content/child/service_worker/service_worker_network_provider.h b/content/child/service_worker/service_worker_network_provider.h
index c991aecb80f7240f0394f3b3df940a49acf9d9c2..52f066256cc7563f91e272b6f1c7e55fdc6199a8 100644
--- a/content/child/service_worker/service_worker_network_provider.h
+++ b/content/child/service_worker/service_worker_network_provider.h
@@ -18,12 +18,13 @@
namespace blink {
class WebLocalFrame;
+class WebServiceWorkerNetworkProvider;
} // namespace blink
namespace content {
-class ServiceWorkerProviderContext;
struct RequestNavigationParams;
+class ServiceWorkerProviderContext;
// A unique provider_id is generated for each instance.
// Instantiated prior to the main resource load being started and remains
@@ -35,22 +36,20 @@ struct RequestNavigationParams;
//
// Basically, it's a scoped integer that sends an ipc upon construction
// and destruction.
-class CONTENT_EXPORT ServiceWorkerNetworkProvider
- : public base::SupportsUserData::Data {
+class CONTENT_EXPORT ServiceWorkerNetworkProvider {
public:
- // Ownership is transferred to the DocumentState.
- static void AttachToDocumentState(
- base::SupportsUserData* document_state,
- std::unique_ptr<ServiceWorkerNetworkProvider> network_provider);
-
- static ServiceWorkerNetworkProvider* FromDocumentState(
- base::SupportsUserData* document_state);
-
- static std::unique_ptr<ServiceWorkerNetworkProvider> CreateForNavigation(
- int route_id,
- const RequestNavigationParams& request_params,
- blink::WebLocalFrame* frame,
- bool content_initiated);
+ // Creates a ServiceWorkerNetworkProvider for navigation and wraps it
+ // with WebServiceWorkerNetworkProvider to be owned by Blink.
+ static std::unique_ptr<blink::WebServiceWorkerNetworkProvider>
+ CreateForNavigation(int route_id,
+ const RequestNavigationParams& request_params,
+ blink::WebLocalFrame* frame,
+ bool content_initiated);
+
+ // Returns inward ServiceWorkerNetworkProvider. Valid only for
falken 2017/03/10 08:29:08 nit: "inward" is still odd, maybe we can just remo
kinuko 2017/03/10 11:35:46 Done.
+ // WebServiceWorkerNetworkProvider created by CreateForNavigation.
+ static ServiceWorkerNetworkProvider* FromWebServiceWorkerNetworkProvider(
+ blink::WebServiceWorkerNetworkProvider*);
// PlzNavigate
// The |browser_provider_id| is initialized by the browser for navigations.
@@ -61,8 +60,9 @@ class CONTENT_EXPORT ServiceWorkerNetworkProvider
ServiceWorkerNetworkProvider(int route_id,
ServiceWorkerProviderType type,
bool is_parent_frame_secure);
+
ServiceWorkerNetworkProvider();
- ~ServiceWorkerNetworkProvider() override;
+ ~ServiceWorkerNetworkProvider();
int provider_id() const { return provider_id_; }
ServiceWorkerProviderContext* context() const { return context_.get(); }

Powered by Google App Engine
This is Rietveld 408576698