Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerNetworkProvider.h

Issue 2733283004: Expose WebServiceWorkerNetworkProvider on DataSource (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerNetworkProvider.h
diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerNetworkProvider.h b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerNetworkProvider.h
similarity index 90%
rename from third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerNetworkProvider.h
rename to third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerNetworkProvider.h
index 7e5c111bc2c6568738139fbecb81212f8993b6ed..338ae8a0b90202c13b444138cda0da048664a579 100644
--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerNetworkProvider.h
+++ b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerNetworkProvider.h
@@ -33,13 +33,15 @@
namespace blink {
-class WebDataSource;
class WebURLRequest;
// This interface is implemented by the client and is only called on the main
// thread. Used by ServiceWorker and SharedWorker. isControlledByServiceWorker()
// and serviceWorkerID() are to be implemented only by SharedWorker's provider,
// as they are needed only for controllee workers.
+//
+// An instance of this class is owned by the associated DataSource, e.g.
Nate Chapin 2017/03/09 19:52:07 e.g. -> i.e. ? Are there plans to have non-Docume
kinuko 2017/03/10 01:51:03 No, but we may start to associate this with non-do
+// DocumentLoader.
class WebServiceWorkerNetworkProvider {
public:
virtual ~WebServiceWorkerNetworkProvider() {}
@@ -47,15 +49,15 @@ class WebServiceWorkerNetworkProvider {
// A request is about to be sent out, and the client may modify it. Request
// is writable, and changes to the URL, for example, will change the request
// made.
- virtual void willSendRequest(WebDataSource*, WebURLRequest&) {}
+ virtual void willSendRequest(WebURLRequest&) {}
// Whether the document associated with WebDataSource is controlled by the
// ServiceWorker.
- virtual bool isControlledByServiceWorker(WebDataSource&) { return false; }
+ virtual bool isControlledByServiceWorker() { return false; }
// Returns an identifier of the service worker controlling the document
// associated with the WebDataSource.
- virtual int64_t serviceWorkerID(WebDataSource&) { return -1; }
+ virtual int64_t serviceWorkerID() { return -1; }
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698