components/metrics/leak_detector/leak_detector.h - Issue 2733283002: Require explicit selection of traits for LazyInstance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/leak_detector/leak_detector.h

Issue 2733283002: Require explicit selection of traits for LazyInstance (Closed)

Patch Set: l10n again Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/leak_detector/leak_detector.h

diff --git a/components/metrics/leak_detector/leak_detector.h b/components/metrics/leak_detector/leak_detector.h

index de5d40f900e8de1b52fd66db097268386ac2f540..fb208990f3994c305ff886d5dc3aa24ccc2a2e34 100644

--- a/components/metrics/leak_detector/leak_detector.h

+++ b/components/metrics/leak_detector/leak_detector.h

@@ -23,7 +23,7 @@

namespace base {

template <typename T>

-struct DefaultLazyInstanceTraits;

+struct LazyInstanceTraitsBase;

}

namespace metrics {

@@ -86,7 +86,7 @@ class LeakDetector {

void RemoveObserver(Observer* observer);

private:

- friend base::DefaultLazyInstanceTraits<LeakDetector>;

+ friend base::LazyInstanceTraitsBase<LeakDetector>;

FRIEND_TEST_ALL_PREFIXES(LeakDetectorTest, NotifyObservers);

// Keep these private, as this class is meant to be initialized only through