Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 2733283002: Require explicit selection of traits for LazyInstance (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_form_conversion_utils.cc
diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc
index b92ff5f757e1d0f71f0f63e064422090d27e3a88..20c9ca72572634dd20a37c3cc869b4721b8ee213 100644
--- a/components/autofill/content/renderer/password_form_conversion_utils.cc
+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc
@@ -105,7 +105,7 @@ re2::RE2* CreateMatcher(void* instance, const char* pattern) {
}
struct LoginAndSignupLazyInstanceTraits
- : public base::DefaultLazyInstanceTraits<re2::RE2> {
+ : public base::internal::DestructorAtExitLazyInstanceTraits<re2::RE2> {
static re2::RE2* New(void* instance) {
return CreateMatcher(instance, kLoginAndSignupRegex);
}
@@ -308,7 +308,7 @@ const char kPasswordSiteUrlRegex[] =
"passwords(?:-[a-z-]+\\.corp)?\\.google\\.com";
struct PasswordSiteUrlLazyInstanceTraits
- : public base::DefaultLazyInstanceTraits<re2::RE2> {
+ : public base::internal::DestructorAtExitLazyInstanceTraits<re2::RE2> {
static re2::RE2* New(void* instance) {
return CreateMatcher(instance, kPasswordSiteUrlRegex);
}

Powered by Google App Engine
This is Rietveld 408576698