chrome/browser/extensions/api/image_writer_private/removable_storage_provider.cc - Issue 2733283002: Require explicit selection of traits for LazyInstance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/removable_storage_provider.cc

Issue 2733283002: Require explicit selection of traits for LazyInstance (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_content_browser_client.cc ('K') | « chrome/browser/extensions/api/image_writer_private/operation_manager.cc ('k') | chrome/browser/extensions/api/input_ime/input_ime_api.cc » ('j') | chrome/browser/safe_browsing/threat_details.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/removable_storage_provider.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/removable_storage_provider.cc b/chrome/browser/extensions/api/image_writer_private/removable_storage_provider.cc

index 42b40f7f4991c25b16aa815056d858889ce3e8d1..a3cf5786c20398541cd97128d51d48e20df0cb67 100644

--- a/chrome/browser/extensions/api/image_writer_private/removable_storage_provider.cc

+++ b/chrome/browser/extensions/api/image_writer_private/removable_storage_provider.cc

@@ -10,7 +10,8 @@

namespace extensions {

// A device list to be returned when testing.

-static base::LazyInstance<scoped_refptr<StorageDeviceList> > g_test_device_list;

+static base::LazyInstance<scoped_refptr<StorageDeviceList>>::DestructorAtExit

+ g_test_device_list;

Nico 2017/03/07 21:43:02 likewsie

scottmg 2017/03/07 21:56:30 Done.

// TODO(haven): Udev code may be duplicated in the Chrome codebase.

// https://code.google.com/p/chromium/issues/detail?id=284898