Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: extensions/common/manifest_handlers/icons_handler.cc

Issue 2733283002: Require explicit selection of traits for LazyInstance (Closed)
Patch Set: l10n again Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/manifest_handlers/icons_handler.h" 5 #include "extensions/common/manifest_handlers/icons_handler.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
11 #include "base/strings/string_number_conversions.h" 11 #include "base/strings/string_number_conversions.h"
12 #include "base/strings/utf_string_conversions.h" 12 #include "base/strings/utf_string_conversions.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 #include "extensions/common/constants.h" 14 #include "extensions/common/constants.h"
15 #include "extensions/common/extension.h" 15 #include "extensions/common/extension.h"
16 #include "extensions/common/file_util.h" 16 #include "extensions/common/file_util.h"
17 #include "extensions/common/manifest_constants.h" 17 #include "extensions/common/manifest_constants.h"
18 #include "extensions/common/manifest_handler_helpers.h" 18 #include "extensions/common/manifest_handler_helpers.h"
19 #include "extensions/strings/grit/extensions_strings.h" 19 #include "extensions/strings/grit/extensions_strings.h"
20 #include "ui/gfx/geometry/size.h" 20 #include "ui/gfx/geometry/size.h"
21 21
22 namespace extensions { 22 namespace extensions {
23 23
24 namespace keys = manifest_keys; 24 namespace keys = manifest_keys;
25 25
26 static base::LazyInstance<ExtensionIconSet> g_empty_icon_set = 26 static base::LazyInstance<ExtensionIconSet>::DestructorAtExit g_empty_icon_set =
27 LAZY_INSTANCE_INITIALIZER; 27 LAZY_INSTANCE_INITIALIZER;
28 28
29 // static 29 // static
30 const ExtensionIconSet& IconsInfo::GetIcons(const Extension* extension) { 30 const ExtensionIconSet& IconsInfo::GetIcons(const Extension* extension) {
31 IconsInfo* info = static_cast<IconsInfo*>( 31 IconsInfo* info = static_cast<IconsInfo*>(
32 extension->GetManifestData(keys::kIcons)); 32 extension->GetManifestData(keys::kIcons));
33 return info ? info->icons : g_empty_icon_set.Get(); 33 return info ? info->icons : g_empty_icon_set.Get();
34 } 34 }
35 35
36 // static 36 // static
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 extension, 80 extension,
81 IDS_EXTENSION_LOAD_ICON_FAILED, 81 IDS_EXTENSION_LOAD_ICON_FAILED,
82 error); 82 error);
83 } 83 }
84 84
85 const std::vector<std::string> IconsHandler::Keys() const { 85 const std::vector<std::string> IconsHandler::Keys() const {
86 return SingleKey(keys::kIcons); 86 return SingleKey(keys::kIcons);
87 } 87 }
88 88
89 } // namespace extensions 89 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698