Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: content/browser/webrtc/webrtc_internals.h

Issue 2733283002: Require explicit selection of traits for LazyInstance (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEBRTC_WEBRTC_INTERNALS_H_ 5 #ifndef CONTENT_BROWSER_WEBRTC_WEBRTC_INTERNALS_H_
6 #define CONTENT_BROWSER_WEBRTC_WEBRTC_INTERNALS_H_ 6 #define CONTENT_BROWSER_WEBRTC_WEBRTC_INTERNALS_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <queue> 9 #include <queue>
10 #include <string> 10 #include <string>
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 protected: 116 protected:
117 // Constructor/Destructor are protected to allow tests to derive from the 117 // Constructor/Destructor are protected to allow tests to derive from the
118 // class and do per-instance testing without having to use the global 118 // class and do per-instance testing without having to use the global
119 // instance. 119 // instance.
120 // The default ctor sets |aggregate_updates_ms| to 500ms. 120 // The default ctor sets |aggregate_updates_ms| to 500ms.
121 WebRTCInternals(); 121 WebRTCInternals();
122 WebRTCInternals(int aggregate_updates_ms, bool should_block_power_saving); 122 WebRTCInternals(int aggregate_updates_ms, bool should_block_power_saving);
123 ~WebRTCInternals() override; 123 ~WebRTCInternals() override;
124 124
125 private: 125 private:
126 friend struct base::DefaultLazyInstanceTraits<WebRTCInternals>; 126 friend struct base::LazyInstanceTraitsBase<WebRTCInternals>;
127 FRIEND_TEST_ALL_PREFIXES(WebRtcAudioDebugRecordingsBrowserTest, 127 FRIEND_TEST_ALL_PREFIXES(WebRtcAudioDebugRecordingsBrowserTest,
128 CallWithAudioDebugRecordings); 128 CallWithAudioDebugRecordings);
129 FRIEND_TEST_ALL_PREFIXES(WebRtcAudioDebugRecordingsBrowserTest, 129 FRIEND_TEST_ALL_PREFIXES(WebRtcAudioDebugRecordingsBrowserTest,
130 CallWithAudioDebugRecordingsEnabledThenDisabled); 130 CallWithAudioDebugRecordingsEnabledThenDisabled);
131 FRIEND_TEST_ALL_PREFIXES(WebRtcAudioDebugRecordingsBrowserTest, 131 FRIEND_TEST_ALL_PREFIXES(WebRtcAudioDebugRecordingsBrowserTest,
132 TwoCallsWithAudioDebugRecordings); 132 TwoCallsWithAudioDebugRecordings);
133 FRIEND_TEST_ALL_PREFIXES(WebRtcInternalsTest, 133 FRIEND_TEST_ALL_PREFIXES(WebRtcInternalsTest,
134 AudioDebugRecordingsFileSelectionCanceled); 134 AudioDebugRecordingsFileSelectionCanceled);
135 135
136 void SendUpdate(const char* command, 136 void SendUpdate(const char* command,
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 std::queue<PendingUpdate> pending_updates_; 256 std::queue<PendingUpdate> pending_updates_;
257 const int aggregate_updates_ms_; 257 const int aggregate_updates_ms_;
258 258
259 // Weak factory for this object that we use for bulking up updates. 259 // Weak factory for this object that we use for bulking up updates.
260 base::WeakPtrFactory<WebRTCInternals> weak_factory_; 260 base::WeakPtrFactory<WebRTCInternals> weak_factory_;
261 }; 261 };
262 262
263 } // namespace content 263 } // namespace content
264 264
265 #endif // CONTENT_BROWSER_WEBRTC_WEBRTC_INTERNALS_H_ 265 #endif // CONTENT_BROWSER_WEBRTC_WEBRTC_INTERNALS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698