MD Settings: add extension-control indicator for autofill and password.

chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
index b5cfb554c728540d62ab4dbf1de87741856dfdb8..a4abcf059a98ad173883bc1058776616195a35f8 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
@@ -46,5 +46,23 @@ Polymer({
       settings.navigateTo(settings.Route.MANAGE_PASSWORDS);
     }
   },
+
+  /** @private */
+  onExtensionDisable_: function() {
+    // TODO(dbeam): this is a pretty huge bummer. It means there are things
+    // (inputs) that our prefs system is not observing. And that changes from
+    // other sources (i.e. disabling/enabling an extension from
+    // chrome://extensions or from the omnibox directly) will not update
+    // |this.prefs.proxy| directly (nor the UI). We should fix this eventually.
+    this.fire('refresh-pref', 'proxy');

[dschuyler, 2017/03/07 22:22:48]

It looks like this was copied from system_page.js
Is it really 'proxy' that we want to refresh here? I may be misunderstanding,
please tell me more about how this works (or whether I'm correct and this
shouldn't be 'proxy').

[Dan Beam, 2017/03/07 22:43:20]

no, as far as I can tell this is a completely unrelated pref path

scottchen@: only some things aren't refreshed.  in fact, I think only the New
Tab page might need this.  proxy and other things might be OK.

did you verify you actually need a refresh()?  the fact that this code refreshes
the wrong pref implies "no" :)

[scottchen, 2017/03/08 00:40:21]

Removed this and UI still updates, so it looks like we don't need this.

+  },
+
+  /** @private */

[Dan Beam, 2017/03/07 22:43:20]

@param

[scottchen, 2017/03/08 00:40:21]

Done.

+  secClass_: function(condition) {

[Dan Beam, 2017/03/07 22:43:20]

condition should be named less generically

[scottchen, 2017/03/08 00:40:21]

Done.

+    // TODO(scottchen): Having to do this is kind of annoying, but it'll be a
+    // temporary patch. As we have plans to move the toggle completely into the
+    // subpages themselves, this code *should* be eliminated soon.

[scottchen, 2017/03/07 21:39:34]

See "remove toggles from the top-level and add ON/OFF toggles to each respected
subpage" in this audit tracker:
https://docs.google.com/spreadsheets/d/17uvG_CTZ7N16B7hSdobwSc8VQO6xFPk2Q3Hz4...

+    return condition ? 'secondary-action' : '';
+  },
 });
 })();