Convert snakecase enum names to camelcase when stringified.

tools/json_schema_compiler/cc_generator.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from code import Code
 from model import PropertyType
 import cpp_util
 import schema_util
 import util_cc_helper
 
@@ skipping 872 matching lines @@
     classname = cpp_util.Classname(schema_util.StripNamespace(type_.name))
 
     if cpp_namespace is not None:
       c.Append('// static')
     maybe_namespace = '' if cpp_namespace is None else '%s::' % cpp_namespace
 
     c.Sblock('std::string %sToString(%s enum_param) {' %
                  (maybe_namespace, classname))
     c.Sblock('switch (enum_param) {')
     for enum_value in self._type_helper.FollowRef(type_).enum_values:
+      name = enum_value.name
+      if 'camel_case_enum_to_string' in self._namespace.compiler_options:

[not at google - send to devlin, 2014/05/13 20:18:22]

you might want to move this camel-casing logic here:

https://code.google.com/p/chromium/codesearch#chromium/src/tools/json_schema_...

close to the code that converts to the "unix name" of a function (I guess this
is snake case?).

somebody else might need it, and that's a consistent place to put it.

[David Tseng, 2014/05/13 23:16:14]

Done.

+        # Convert to camel case.
+        snake = name
+        camel = ""
+        i = 0
+        while i < len(snake):
+          if snake[i] == "_" and (i + 1) < len(snake):
+            camel += snake[i + 1].upper()

[not at google - send to devlin, 2014/05/13 20:18:22]

+= on strings is expensive because it creates a new string each time. better to
have a list and then ''.join it at the end.

[David Tseng, 2014/05/13 23:16:14]

Done.

+            i = i + 2
+          else:
+            camel += snake[i]
+            i = i + 1
+        name = camel
       (c.Append('case %s: ' % self._type_helper.GetEnumValue(type_, enum_value))
-        .Append('  return "%s";' % enum_value.name))
+        .Append('  return "%s";' % name))
     (c.Append('case %s:' % self._type_helper.GetEnumNoneValue(type_))
       .Append('  return "";')
       .Eblock('}')
       .Append('NOTREACHED();')
       .Append('return "";')
       .Eblock('}')
     )
     return c
 
   def _GenerateEnumFromString(self, cpp_namespace, type_):
@@ skipping 105 matching lines @@
     if self._generate_error_messages:
       params = list(params) + ['base::string16* error']
     return ', '.join(str(p) for p in params)
 
   def _GenerateArgs(self, args):
     """Builds the argument list for a function, given an array of arguments.
     """
     if self._generate_error_messages:
       args = list(args) + ['error']
     return ', '.join(str(a) for a in args)