Convert snakecase enum names to camelcase when stringified.

tools/json_schema_compiler/idl_schema.py

 #! /usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import itertools
 import json
 import os.path
 import re
 import sys
@@ skipping 300 matching lines @@
             raise ValueError('Did not process %s %s' % (child.cls, child))
         enum.append(enum_value)
       elif node.cls == 'Comment':
         self.description = ProcessComment(node.GetName())[0]
       else:
         sys.exit('Did not process %s %s' % (node.cls, node))
     result = {'id' : self.node.GetName(),
               'description': self.description,
               'type': 'string',
               'enum': enum}
     for property_name in (

[not at google - send to devlin, 2014/05/14 23:43:43]

should fit on 1 line now

[David Tseng, 2014/05/15 01:12:37]

Not anymore with the below change.

-        'inline_doc', 'noinline_doc', 'nodoc', 'cpp_omit_enum_type',):
+        'inline_doc', 'noinline_doc', 'nodoc',):
       if self.node.GetProperty(property_name):
         result[property_name] = True

[not at google - send to devlin, 2014/05/14 23:43:43]

hm I wonder if the "default" value for IDL attributes is True? that would mean
that the code could really stay the same, except instead of =True here, it would
be the result from GetProperty().

seems more consistent than doing the same check twice.

[David Tseng, 2014/05/15 01:12:37]

Done (after verifying True gets returned for properties).

+    if self.node.GetProperty('cpp_enum_prefix_override'):
+      result['cpp_enum_prefix_override'] = self.node.GetProperty(
+          'cpp_enum_prefix_override')
     if self.node.GetProperty('deprecated'):
         result[deprecated] = self.node.GetProperty('deprecated')
     return result
 
 
 class Namespace(object):
   '''
   Given an IDLNode representing an IDL namespace, converts into a Python
   dictionary that the JSON schema compiler expects to see.
   '''
@@ skipping 65 matching lines @@
 
   def __init__(self, idl):
     self.idl = idl
 
   def process(self):
     namespaces = []
     nodoc = False
     internal = False
     description = None
     platforms = None
-    compiler_options = None
+    compiler_options = {}
     deprecated = None
     for node in self.idl:
       if node.cls == 'Namespace':
         if not description:
           # TODO(kalman): Go back to throwing an error here.
           print('%s must have a namespace-level comment. This will '
                            'appear on the API summary page.' % node.GetName())
           description = ''
         namespace = Namespace(node, description, nodoc, internal,
                               platforms=platforms,
-                              compiler_options=compiler_options,
+                              compiler_options=compiler_options or None,
                               deprecated=deprecated)
         namespaces.append(namespace.process())
         nodoc = False
         internal = False
         platforms = None
         compiler_options = None
       elif node.cls == 'Copyright':
         continue
       elif node.cls == 'Comment':
         description = node.GetName()
       elif node.cls == 'ExtAttribute':
         if node.name == 'nodoc':
           nodoc = bool(node.value)
         elif node.name == 'internal':
           internal = bool(node.value)
         elif node.name == 'platforms':
           platforms = list(node.value)
         elif node.name == 'implemented_in':
-          compiler_options = {'implemented_in': node.value}
+          compiler_options['implemented_in'] = node.value
+        elif node.name == 'camel_case_enum_to_string':
+          compiler_options['camel_case_enum_to_string'] = node.value
         elif node.name == 'deprecated':
           deprecated = str(node.value)
         else:
           continue
       else:
         sys.exit('Did not process %s %s' % (node.cls, node))
     return namespaces
 
 
 def Load(filename):
@@ skipping 16 matching lines @@
   Dump a json serialization of parse result for the IDL files whose names
   were passed in on the command line.
   '''
   for filename in sys.argv[1:]:
     schema = Load(filename)
     print json.dumps(schema, indent=2)
 
 
 if __name__ == '__main__':
   Main()