Convert snakecase enum names to camelcase when stringified.

tools/json_schema_compiler/model.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os.path
 
 from json_parse import OrderedDict
 from memoize import memoize
 
 
@@ skipping 392 matching lines @@
   - |description| a description of the property (if provided)
   """
   def __init__(self, json):
     if isinstance(json, dict):
       self.name = json['name']
       self.description = json.get('description')
     else:
       self.name = json
       self.description = None
 
+

[not at google - send to devlin, 2014/05/13 23:45:47]

only 1 blank line

[David Tseng, 2014/05/14 02:16:14]

Done.

+  def CamelName(self):
+    return SnakeToCamel(self.name)
+
 class _Enum(object):
   """Superclass for enum types with a "name" field, setting up repr/eq/ne.
   Enums need to do this so that equality/non-equality work over pickling.
   """
   @staticmethod
   def GetAll(cls):
     """Yields all _Enum objects declared in |cls|.
     """
     for prop_key in dir(cls):
       prop_value = getattr(cls, prop_key)
@@ skipping 54 matching lines @@
         unix_name.append('_')
     if c == '.':
       # Replace hello.world with hello_world.
       unix_name.append('_')
     else:
       # Everything is lowercase.
       unix_name.append(c.lower())
   return ''.join(unix_name)
 
 
+def SnakeToCamel(snake):

[not at google - send to devlin, 2014/05/13 23:45:47]

could you write some unit tests? see model_test.py.

[David Tseng, 2014/05/14 02:16:14]

Done.

+  ''' Converts a snake_cased_string to a camelCasedOne. '''
+  camel = []
+  i = 0
+  while i < len(snake):
+    if snake[i] == "_" and (i + 1) < len(snake):

[not at google - send to devlin, 2014/05/13 23:45:47]

single quotes

[David Tseng, 2014/05/14 02:16:14]

Done.

+      camel.append(snake[i + 1].upper())
+      i = i + 2

[not at google - send to devlin, 2014/05/13 23:45:47]

+= 2

[David Tseng, 2014/05/14 02:16:14]

Done.

+    else:
+      camel.append(snake[i])
+      i = i + 1

[not at google - send to devlin, 2014/05/13 23:45:47]

+= 1

[David Tseng, 2014/05/14 02:16:14]

Done.

+  return ''.join(camel)

[not at google - send to devlin, 2014/05/13 23:45:47]

the above said, it might be simpler (and more efficient) to split on '_',
uppercase each part (except the first), then join again.

[David Tseng, 2014/05/14 02:16:14]

Sounds like you'd still end up with some kind of loop construct.

I'm going to leave as is since split is likely to take as much time as iterating
through the string. Can change if you feel strongly. Also, note that this code
path currently only gets hit for ax_enums.idl.

[not at google - send to devlin, 2014/05/14 16:18:14]

Actually split is likely to be much faster. Iterating over strings is super slow
in Python and the native string operations are all implemented in native code.

That said, given this code isn't on the critical path, it doesn't really matter.
What you have is fine.

[David Tseng, 2014/05/14 18:11:31]

Thanks; good to know.

+
+
 def _StripNamespace(name, namespace):
   if name.startswith(namespace.name + '.'):
     return name[len(namespace.name + '.'):]
   return name
 
 
 def _GetModelHierarchy(entity):
   """Returns the hierarchy of the given model entity."""
   hierarchy = []
   while entity is not None:
@@ skipping 73 matching lines @@
   # Sanity check: platforms should not be an empty list.
   if not json['platforms']:
     raise ValueError('"platforms" cannot be an empty list')
   platforms = []
   for platform_name in json['platforms']:
     for platform_enum in _Enum.GetAll(Platforms):
       if platform_name == platform_enum.name:
         platforms.append(platform_enum)
         break
   return platforms