Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: include/v8.h

Issue 2733203002: FunctionEntryHook: require no-snapshot build (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index ead6efa42c8dd2cce53616df84e86a02136280e0..a1c904a9a2edd0f1542ca99c5ee029313de5ae8f 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -6357,8 +6357,9 @@ class V8_EXPORT Isolate {
* The optional entry_hook allows the host application to provide the
* address of a function that's invoked on entry to every V8-generated
* function. Note that entry_hook is invoked at the very start of each
- * generated function. Furthermore, if an entry_hook is given, V8 will
- * not use a snapshot, including custom snapshots.
+ * generated function.
+ * An entry_hook can only be provided in no-snapshot builds; in snapshot
+ * builds it must be NULL.
jochen (gone - plz use gerrit) 2017/03/07 11:42:44 nit nullptr
Jakob Kummerow 2017/03/07 12:43:42 Done.
*/
FunctionEntryHook entry_hook;
« no previous file with comments | « BUILD.gn ('k') | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698