FunctionEntryHook: require no-snapshot build

src/api.cc

Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 866a0bc22441e84f5339397ba42f9ce2c190ea44..17d8c2de70d445dd683c8954e4de1c0d6fac81d9 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -8154,6 +8154,10 @@ Isolate* Isolate::New(const Isolate::CreateParams& params) {
     isolate->set_snapshot_blob(i::Snapshot::DefaultSnapshotBlob());
   }
   if (params.entry_hook) {
+#ifdef V8_USE_SNAPSHOT
+    // Setting a FunctionEntryHook is only supported in no-snapshot builds.
+    CHECK(false);

[jochen (gone - plz use gerrit), 2017/03/07 10:37:00]

can you make this an ApiCheck so it has some useful error message?

please also add a comment to the entry_hook declaration in v8.h

[Jakob Kummerow, 2017/03/07 10:47:14]

Done.
Done.

+#endif
     isolate->set_function_entry_hook(params.entry_hook);
   }
   auto code_event_handler = params.code_event_handler;