Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.cc

Issue 2733133002: Combine 2 exclusions in Layout Opportunity Tree if they shadow each other (Closed)
Patch Set: delete unreachable return statement Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.cc b/third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.cc
index 90a5672f26aaffce6f1af848b8f92185dba9b3a6..aeaf7c304a588ec3bc98275732f7a756d8d29119 100644
--- a/third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.cc
+++ b/third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.cc
@@ -25,11 +25,13 @@ bool NGLogicalRect::operator==(const NGLogicalRect& other) const {
}
String NGLogicalRect::ToString() const {
- return String::format("%s,%s %sx%s",
- offset.inline_offset.toString().ascii().data(),
- offset.block_offset.toString().ascii().data(),
- size.inline_size.toString().ascii().data(),
- size.block_size.toString().ascii().data());
+ return IsEmpty()
+ ? "(empty)"
+ : String::format("%sx%s at (%s,%s)",
+ size.inline_size.toString().ascii().data(),
+ size.block_size.toString().ascii().data(),
+ offset.inline_offset.toString().ascii().data(),
+ offset.block_offset.toString().ascii().data());
}
std::ostream& operator<<(std::ostream& os, const NGLogicalRect& value) {

Powered by Google App Engine
This is Rietveld 408576698