Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.cc

Issue 2733133002: Combine 2 exclusions in Layout Opportunity Tree if they shadow each other (Closed)
Patch Set: delete unreachable return statement Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/ng/ng_layout_opportunity_tree_node.h" 5 #include "core/layout/ng/ng_layout_opportunity_tree_node.h"
6 6
7 namespace blink { 7 namespace blink {
8 8
9 NGLayoutOpportunityTreeNode::NGLayoutOpportunityTreeNode( 9 NGLayoutOpportunityTreeNode::NGLayoutOpportunityTreeNode(
10 const NGLogicalRect opportunity) 10 const NGLogicalRect opportunity)
11 : opportunity(opportunity), exclusion(nullptr) { 11 : opportunity(opportunity), combined_exclusion(nullptr) {
12 exclusion_edge.start = opportunity.offset.inline_offset; 12 exclusion_edge.start = opportunity.offset.inline_offset;
13 exclusion_edge.end = exclusion_edge.start + opportunity.size.inline_size; 13 exclusion_edge.end = exclusion_edge.start + opportunity.size.inline_size;
14 } 14 }
15 15
16 NGLayoutOpportunityTreeNode::NGLayoutOpportunityTreeNode( 16 NGLayoutOpportunityTreeNode::NGLayoutOpportunityTreeNode(
17 const NGLogicalRect opportunity, 17 const NGLogicalRect opportunity,
18 NGEdge exclusion_edge) 18 NGEdge exclusion_edge)
19 : opportunity(opportunity), 19 : opportunity(opportunity),
20 exclusion_edge(exclusion_edge), 20 exclusion_edge(exclusion_edge),
21 exclusion(nullptr) {} 21 combined_exclusion(nullptr) {}
22 22
23 String NGLayoutOpportunityTreeNode::ToString() const { 23 String NGLayoutOpportunityTreeNode::ToString() const {
24 return String::format( 24 return String::format("Opportunity: '%s' Exclusion: '%s'",
25 "Opportunity: '%s' Exclusion: '%s'", 25 opportunity.ToString().ascii().data(),
26 opportunity.ToString().ascii().data(), 26 combined_exclusion
27 exclusion ? exclusion->ToString().ascii().data() : "null"); 27 ? combined_exclusion->ToString().ascii().data()
28 : "null");
28 } 29 }
29 30
30 DEFINE_TRACE(NGLayoutOpportunityTreeNode) { 31 DEFINE_TRACE(NGLayoutOpportunityTreeNode) {
31 visitor->trace(left); 32 visitor->trace(left);
32 visitor->trace(bottom); 33 visitor->trace(bottom);
33 visitor->trace(right); 34 visitor->trace(right);
34 } 35 }
35 36
36 } // namespace blink 37 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698